Project

General

Profile

Actions
Copy link

Bug #16524

closed

we should not use .size to check if a collection is empty

Added by Nicolas CHARLES almost 5 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Performance and scalability
Target version:
5.0.16
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

see https://pavelfatin.com/scala-collections-tips-and-tricks/

.size for to iterate over the whole collection/list, so we should use isEmpty or seq.lengthCompare(n)

Subtasks 1 (0 open — 1 closed)

Bug #16606: same as parent ticket, but for .lengthReleasedFrançois ARMANDActions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #16537: Node never updated because of nonEmpty in place of isEmptyReleasedNicolas CHARLESActions
Actions
Copy link

Also available in: Atom PDF