Project

General

Profile

Actions

Bug #16606

closed

Bug #16524: we should not use .size to check if a collection is empty

same as parent ticket, but for .length

Added by Nicolas CHARLES about 4 years ago. Updated about 4 years ago.

Status:
Released
Priority:
N/A
Category:
Performance and scalability
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

we are using a lot of .length to check if strings are empty, but we should use isEmpty, even if perf improvement s minimal (see https://www.baeldung.com/java-string-performance)


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #16607: Merge error in #16606ReleasedFrançois ARMANDActions
Actions #1

Updated by Nicolas CHARLES about 4 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #2

Updated by Nicolas CHARLES about 4 years ago

  • Description updated (diff)
  • Category deleted (Performance and scalability)
  • Assignee deleted (Nicolas CHARLES)
  • Target version deleted (5.0.16)
  • Name check deleted (To do)
Actions #3

Updated by Nicolas CHARLES about 4 years ago

  • Category set to Performance and scalability
  • Target version set to 5.0.16
Actions #4

Updated by Nicolas CHARLES about 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee set to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2735
Actions #5

Updated by Nicolas CHARLES about 4 years ago

  • Status changed from Pending technical review to Pending release
Actions #6

Updated by François ARMAND about 4 years ago

  • Fix check changed from To do to Checked
Actions #7

Updated by Alexis Mousset about 4 years ago

  • Name check set to Reviewed
Actions #8

Updated by Vincent MEMBRÉ about 4 years ago

This bug has been fixed in Rudder 5.0.16 which was released today.

Actions #9

Updated by Vincent MEMBRÉ about 4 years ago

  • Related to Bug #16607: Merge error in #16606 added
Actions #10

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released
Actions

Also available in: Atom PDF