Project

General

Profile

Actions
Copy link

Bug #16701

closed

Technique editor fails with internal error

Added by Nicolas CHARLES almost 5 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Benoît PECCATTE
Category:
API
Target version:
5.0.16
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

After upgrading Rudder from 5.0 to 6.0 (see https://issues.rudder.io/issues/16699), ncf fails - errors are

[Mon Feb 10 15:50:44.748299 2020] [:error] [pid 22101] ERROR: Unknown internal error during authentication
[Mon Feb 10 15:50:44.748321 2020] [:error] [pid 22101] Cause: 'Request' object has no attribute 'is_xhr'
[Mon Feb 10 15:50:44.748324 2020] [:error] [pid 22101] Traceback (most recent call last):
[Mon Feb 10 15:50:44.748326 2020] [:error] [pid 22101]   File "/usr/share/ncf/api/ncf_api_flask_app/views.py", line 99, in get_auth
[Mon Feb 10 15:50:44.748328 2020] [:error] [pid 22101]     success = jsonify ( authentication_result )
[Mon Feb 10 15:50:44.748330 2020] [:error] [pid 22101]   File "/usr/share/ncf-api-virtualenv/lib/python2.7/site-packages/flask/json.py", line 298, in jsonify
[Mon Feb 10 15:50:44.748332 2020] [:error] [pid 22101]     if current_app.config['JSONIFY_PRETTYPRINT_REGULAR'] and not request.is_xhr:
[Mon Feb 10 15:50:44.748334 2020] [:error] [pid 22101]   File "/usr/share/ncf-api-virtualenv/lib/python2.7/site-packages/werkzeug/local.py", line 347, in __getattr__
[Mon Feb 10 15:50:44.748335 2020] [:error] [pid 22101]     return getattr(self._get_current_object(), name)
[Mon Feb 10 15:50:44.748337 2020] [:error] [pid 22101] AttributeError: 'Request' object has no attribute 'is_xhr'
[Mon Feb 10 15:50:44.748339 2020] [:error] [pid 22101]

Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 5 years ago

This is because werkzeug changed their API without warning anybody before hand
We should upgrade flask to 0.12.5 to fix this issue - https://flask.palletsprojects.com/en/1.1.x/changelog/#version-0-12-5 https://flask.palletsprojects.com/en/1.1.x/changelog/#version-0-12-5

Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 5 years ago

  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/1142
Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 5 years ago

  • Target version changed from 6.0.3 to 5.0.16
Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 5 years ago

  • Subject changed from ncf api fails on Centos 7.6.1810 to ncf api fails
Actions
Copy link
 #6

Updated by Nicolas CHARLES almost 5 years ago

  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Actions
Copy link
 #7

Updated by Nicolas CHARLES almost 5 years ago

  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
  • Pull Request changed from https://github.com/Normation/ncf/pull/1142 to https://github.com/Normation/ncf/pull/1143
Actions
Copy link
 #8

Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from In progress to Pending release

Applied in changeset ncf:commit:b0ad0f3785de62cf07b659fd7b16d37508ae8339.

Actions
Copy link
 #9

Updated by Alexis Mousset almost 5 years ago

  • Subject changed from ncf api fails to Technique editor fails with internal error
  • Name check changed from To do to Reviewed
Actions
Copy link
 #10

Updated by Nicolas CHARLES almost 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.16 which was released today.

Actions
Copy link

Also available in: Atom PDF