Bug #16993
closed
Can't insert method to end of method list in technique editor
Description
When adding methods to a new user technique the green "Add+" Button next to "GENERIC METHODS" appears to not working (at least clicking on it doesn't have any effect, no action visible in the firefox console).
After creating a new technique there is a light grey field in the empty "GENERIC METHODS" list where one is supposed to drag and drop the first method.
After dropping a method there, more methods can only be dropped either at the beginning of this method list, or inbetween two existing methods BUT NOT AT THE END of the list.
Ones a method is added it also can't be moved TO THE END of the list, instead (all) other methods have to be moved UP.
Updated by François ARMAND over 4 years ago
- Category set to Web - Technique editor
- Target version set to 6.0.5
Updated by Raphael GAUTHIER over 4 years ago
- Status changed from New to In progress
Updated by Raphael GAUTHIER over 4 years ago
Hi Tim, thanks for reporting that!
Button "Save" is disabled if there is a problem with the technique we are editing. So after adding generic methods, button becomes disabled until we correctly set all required method parameters.
So had you defined all methods parameters? If so, I cannot reproduce this bug. Which version of Firefox do you use?
About the drag'n drop, it looks like the dnd area at the end of the list is too small, making it hard/almost impossible to drop a method here. We should upsize it. However you can just click on a method to add it at the end of the list
Updated by Raphael GAUTHIER over 4 years ago
- Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/ncf/pull/1164
Updated by Raphael GAUTHIER over 4 years ago
My bad.. We are not talking about the "Save" button but the "Add". This button is a bit confusing, I admit it, it only opens the generic methods menu. We should at least rename it, or give it more sense.
Updated by Tim Taler over 4 years ago
Raphael GAUTHIER wrote in #note-4:
Hi Tim, thanks for reporting that!
Button "Save" is disabled if there is a problem with the technique we are editing. So after adding generic methods, button becomes disabled until we correctly set all required method parameters.
So had you defined all methods parameters? If so, I cannot reproduce this bug. Which version of Firefox do you use?
About the drag'n drop, it looks like the dnd area at the end of the list is too small, making it hard/almost impossible to drop a method here. We should upsize it. However you can just click on a method to add it at the end of the list
it's firefox 74.0
I was just confused about not being able to drop a technique at the end of the list ...
Updated by Raphael GAUTHIER over 4 years ago
- Status changed from In progress to Pending release
Applied in changeset ncf:commit:246e9354c0cdb47085d0fef94e9c6b115a3db9aa.
Updated by Raphael GAUTHIER over 4 years ago
- Related to Bug #17118: Make it easier to drag'n drop methods added
Updated by François ARMAND over 4 years ago
- Fix check changed from To do to Checked
Updated by Alexis Mousset over 4 years ago
- Subject changed from can't insert method to end of method list in technique editor to Can't insert method to end of method list in technique editor
- Name check changed from To do to Reviewed
Updated by Vincent MEMBRÉ over 4 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 6.0.5 which was released today.