Project

General

Profile

Actions

Bug #17109

open

After month of working great and no changes, Rudder agent stopped to expand variables

Added by Félix DALLIDET almost 4 years ago. Updated 3 days ago.

Status:
New
Priority:
N/A
Assignee:
-
Category:
Agent
Target version:
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

On a Rudder node I had an old configuration using "file_lines_present" which showed a very surprising behaviour last week.
The configuration did not change for months on this node.

I had a "file_lines_present" to setup some special crontab rules in /etc/crontab using variables. It has work for months, but suddenly, the variable stopped to be expanded in the file.
The agent was updated 10 days before it happened, so I do not think it is correlated. The reports were "success" even if the variable was not expanded, this is VERY misleading.

Actions #1

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions #2

Updated by François ARMAND over 3 years ago

  • Severity changed from Major - prevents use of part of Rudder | no simple workaround to Critical - prevents main use of Rudder | no workaround | data loss | security
  • Priority changed from 41 to 63
Actions #3

Updated by François ARMAND over 3 years ago

  • Subject changed from Rudder fails to expand variable to After month of working great and no changes, Rudder agent stopped to expand variables
Actions #4

Updated by François ARMAND over 3 years ago

So, after some discussion on the suject:

- variables were defined with a "variable from command". So likely something changed in that command output,
- undefined variables are silently not expanded by cfengine.

We need to address these two problems.

For the first one, we can add a check in all "variable from ..." to validate that after variable definition, the variable is ACTUALLY defined. CFEngine doesn't help for that, but we could exploit some trick (predefined variable to some string like "the variable 'XXXX' is not correctly defined" (also usable as an understandable error message for human where the variable will be used), check that it's not that anymore after method exec)

For the second, we need a definitive solution to avoid that class of bug. I don't see any other solution than "rudder lang" (long term) and "finding a way to change that behavior in cfengine" (short term, but perhaps out of reach).

Actions #5

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.18 to 5.0.19
Actions #6

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.19 to 5.0.20
  • Priority changed from 63 to 61
Actions #7

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.20 to 797
  • Priority changed from 61 to 59
Actions #8

Updated by Benoît PECCATTE over 2 years ago

  • Target version changed from 797 to 6.1.14
  • Priority changed from 59 to 54
Actions #9

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.14 to 6.1.15
Actions #10

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.15 to 6.1.16
Actions #11

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.16 to 6.1.17
Actions #12

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.17 to 6.1.18
Actions #13

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 6.1.18 to 6.1.19
Actions #14

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.19 to 6.1.20
Actions #15

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.20 to 6.1.21
Actions #16

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 6.1.21 to old 6.1 issues to relocate
Actions #17

Updated by Alexis Mousset about 1 year ago

  • Target version changed from old 6.1 issues to relocate to old 6.2 issues to relocate
  • Priority changed from 54 to 0
Actions #18

Updated by Alexis Mousset 7 months ago

  • Target version changed from old 6.2 issues to relocate to 7.2.11
Actions #19

Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 7.2.11 to 1046
Actions #20

Updated by Alexis Mousset 5 months ago

  • Target version changed from 1046 to 7.3.8
Actions #21

Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 7.3.8 to 7.3.9
Actions #22

Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 7.3.9 to 7.3.10
Actions #23

Updated by Vincent MEMBRÉ 3 months ago

  • Target version changed from 7.3.10 to 7.3.11
Actions #24

Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 7.3.11 to 7.3.12
Actions #25

Updated by Vincent MEMBRÉ 3 days ago

  • Target version changed from 7.3.12 to 7.3.13
Actions

Also available in: Atom PDF