Project

General

Profile

Bug #17157

TechniqueVersion ordering algorithm is incorrect

Added by François ARMAND 5 months ago. Updated 2 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

We have a (complicated) method that test for version of technique ordering.
It is incorrectly ordering "1.0.1" and "1.0", nor "1.release3" and "1.release10", or "1.3b" and "1.10a". It also doesn't know about a lot of other version things, like "alpha/beta/etc".

I'm not sure about the exact impact, but that ordering is used in a lot of place (in set, for ex). It seems bad to keep it like that.

Also: I wasn't able to understand current algorithm. It seems that it doesn't have a notion of separator after the first one.

#1

Updated by François ARMAND 5 months ago

  • Status changed from New to In progress
#2

Updated by François ARMAND 5 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/2906
#3

Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 5.0.17 to 5.0.18
#4

Updated by François ARMAND 5 months ago

  • Status changed from Pending technical review to Pending release
#6

Updated by Vincent MEMBRÉ 2 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.18 and 6.1.2 which were released today.

Also available in: Atom PDF