Bug #17334
closed
Property name aren't limited to ascii
Description
When implementing group properties, we relaxed what was authorized as name for properties from [\-_a-zA-Z0-9]+ to UTF-8 "letters" (symbol included).
This seems to be a bad idea and should be reverted.
Updated by François ARMAND over 4 years ago
- Related to User story #7006: Parameter validation in Rudder should accept rudder variables ( ${ } ) added
Updated by François ARMAND over 4 years ago
- Status changed from New to In progress
Updated by François ARMAND over 4 years ago
- Subject changed from Property name aren't limited to ascii anymore to Property name aren't limited to ascii
- Target version changed from 6.1.0~beta3 to 5.0.18
Actually, it's as old as rudder. The problem is not in the parser that correctly limit chars, but in the api which is far too lenient.
The good new is that we are sure than no property with a name out of [\-_0-9a-zA-Z] was used in a directive parameter (or other property default etc).
We should either limit the API to the accepted values in directive parameter, or relaxe what is accepted, but both need to be consistant.
Updated by François ARMAND over 4 years ago
We know that some user use at least latin-15 for property names - and likely they only use these properties for groups and not directive parameters.
Updated by François ARMAND over 4 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/2950
Updated by François ARMAND over 4 years ago
Hum, given what we found, the only correct solution is to relax what is allowed in property names. But I'm not at ease with doing to in a patch release. It can change significantly what was done on nodes/etc.
I think it's better to relax only in 6.1: it goes with other changes on properties and an updated documentation, and it is at least in a minor release.
Updated by François ARMAND over 4 years ago
- Target version changed from 5.0.18 to 6.1.0~beta3
Updated by François ARMAND over 4 years ago
- Pull Request changed from https://github.com/Normation/rudder/pull/2950 to https://github.com/Normation/rudder/pull/2951
Updated by François ARMAND over 4 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|a08cd2c01ed639141bf008cbb71682068f47baef.
Updated by Vincent MEMBRÉ over 4 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 6.1.0~beta3 which was released today.