Project

General

Profile

Actions

Architecture #17426

closed

User story #17375: Properties (node, group, global) should accept comments

Use hocon as an internal format for node properties

Added by François ARMAND almost 4 years ago. Updated almost 4 years ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
To do
Fix check:
Checked
Regression:

Description

If we want to accept comments for node properties, we need to first use an internal format that allow to store them. Today, we are using JValue, which is a (very slow) json format.
That format does not allow comments.
We need to change it to hocon ConfigValue to allows to then have the UI to keep comment.

That first step is only backend and should be (almost) iso behavior. The only change is in array overriding in property hierarchy, since hocon replace parent array in place of extending them. Still, other JValue implementation specific behavior can exist, and we should have that code before 6.1 is released since not having it could lead to later breaking change (while now, the hierarchy feature is new and noone relies on its behavior in prod).


Related issues 1 (0 open1 closed)

Related to Rudder - User story #16347: Group propertiesReleasedNicolas CHARLESActions
Actions #1

Updated by François ARMAND almost 4 years ago

  • Status changed from New to In progress
Actions #2

Updated by François ARMAND almost 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2979
Actions #3

Updated by François ARMAND almost 4 years ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.1.0~rc1 which was released today.

Actions #5

Updated by François ARMAND almost 4 years ago

  • Fix check changed from To do to Checked
Actions #6

Updated by François ARMAND over 3 years ago

Actions

Also available in: Atom PDF