Project

General

Profile

Actions

User story #1767

closed

PT Download a file: no validation of the URL

Added by Fabrice FLORE-THÉBAULT over 13 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
4
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

There is no validation of the URL: URL can accept any input:

URL to download file from: toto is accepted

For me, that raises the questions: what happens if the given URL is wrong? Where and when will it be checked?

And, indeed, curl is very liberal in the form an URL can be, the manpage says:

curl will do its best to use what you pass to it as a URL. It is not trying to validate it as a syntactically correct URL by any means but is instead very liberal with what it accepts.

I guess we should add something like the above sentence as comment for this field, if there is no other validation step at any moment.

Actions #1

Updated by François ARMAND about 13 years ago

  • Target version set to 23
Actions #2

Updated by Jonathan CLARKE about 13 years ago

  • Status changed from New to 2
  • Assignee set to Matthieu CERDA
  • Priority changed from N/A to 4
  • Target version changed from 23 to 2.3.0

I don't think it's our job to validate URLs - either curl can do it, or the user :-)

However, we should add a message to clarify.

Actions #3

Updated by Matthieu CERDA about 13 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:2e014b7d3a049a85deac54346d75ccba5ff3605a.

Actions #4

Updated by Jonathan CLARKE about 13 years ago

  • Status changed from Pending technical review to Released
Actions #5

Updated by almost 13 years ago

  • Subject changed from PT Download a file: no validation of the URL to Pozycjonowanie
  • Description updated (diff)
  • Assignee changed from Matthieu CERDA to Arthur ANGLADE
  • % Done changed from 100 to 0
Actions #6

Updated by Jonathan CLARKE almost 13 years ago

  • Subject changed from Pozycjonowanie to PT Download a file: no validation of the URL
  • Description updated (diff)
  • Assignee changed from Arthur ANGLADE to Matthieu CERDA
  • % Done changed from 0 to 100
Actions #7

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 24 to Rudder
  • Category changed from Policy Templates to Techniques
Actions

Also available in: Atom PDF