Project

General

Profile

Actions

Bug #18015

closed

Remove technique from technique tree when deleting technique in the technique editor

Added by Frédéric COSTANT over 4 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Technique editor
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Priority:
85
Name check:
To do
Fix check:
Checked
Regression:

Description

Rudder version : 6.1.1
Rudder OS : Sles 12

Description : Can't create technique named "Package Absent" because seems to be already existing, but doesn't appear in techniques list.

Notice 1: When running service rudder-jetty restart, the ghost technique "Package Absent" appears, after delete (ok), then want recreate ==> impossible.

It's like the delete action, doesn't clear completly.

See the joined gif animation


Files

bug_rudder.gif (2.39 MB) bug_rudder.gif François ARMAND, 2020-07-21 10:51

Subtasks 1 (0 open1 closed)

Bug #18036: fix failling testReleasedFrançois ARMANDActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #18016: When technique creation fails, it is still displayed in editorRejectedClark ANDRIANASOLOActions
Actions #1

Updated by François ARMAND over 4 years ago

Adding the missing gif (due to #17918)

Actions #2

Updated by François ARMAND over 4 years ago

  • Related to Bug #18016: When technique creation fails, it is still displayed in editor added
Actions #3

Updated by François ARMAND over 4 years ago

We have the full story:

- 1/ when first deleted from editor, data in LDAP (active technique) were not deleted. There should have been an error message or deletion should have been interrupted,
- 2/ the fact that restarting rudder-jetty create back the technique in editor let think that technique files are not correctly deleted or that deletion is not correctly commit in git,
- 3/ when trying to create back technique in editor, there's that error:

Could not create ncf technique <- An error occured during technique update after files were created for ncf Technique Package Absent <- Unexpected: Accumulated: Error when automatically activating technique 'Package_Absent'; cause was: Consistancy: Can not add a technique with id 'Package_Absent' in user library. active technique 'activeTechniqueId=cfc7f8d8-3fff-4935-9874-e71890e7fd9e,techniqueCategoryId=ncf_techniques,techniqueCategoryId=Active Techniques,ou=Rudder,cn=rudder-configuration}' is already defined with such a reference technique.

- 4/ ... but the technique is still created in editor

- 5/ if we delete it (again) from editor, then go to 'settings > active tree', we see the technique. Clicking on it leads to message:

Can not find dependencies. Can not build tree of dependencies for Technique ActiveTechniqueId(cfc7f8d8-3fff-4935-9874-e71890e7fd9e)

(which is OK, since we deleted at least parts of files)

- 6/ deleting technique from 'active tree' screen finally clean the state.

Now we can create back the technique and there's no message anymore.

Correction:
For 1/: We need to make sure to first delete data in base, then in fs/git and show related errors to user, with actionnable hint about what he can do. It will be handled in that ticket.

In 3/: we need to correct error message (s/ncf technique/technique/, give user hint that he can delete corresponding active technique in "settings > active tree" => #18016

For 4/: we should really NOT display a thing in editor if we just told user that it failed => #18016

Actions #4

Updated by François ARMAND over 4 years ago

  • Translation missing: en.field_tag_list set to Sponsored
  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Getting started - demo | first install | Technique editor and level 1 Techniques
  • Priority changed from 0 to 102

Severity to major since it needed a full debug session to understand what was going on.
Visibility to getting started, because it happened during a proto/test.

Actions #5

Updated by Vincent MEMBRÉ over 4 years ago

  • Subject changed from Hidden technique or not quite well cleaned technique to Remove technique from technique tree when deleting technique in the technique editor
  • Category set to Web - Technique editor
  • Target version set to 6.0.8
Actions #6

Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #7

Updated by Vincent MEMBRÉ over 4 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3132
Actions #8

Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from In progress to Pending release
Actions #9

Updated by Vincent MEMBRÉ about 4 years ago

  • Priority changed from 102 to 101
  • Fix check changed from To do to Checked
Actions #10

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.0.8 and 6.1.4 which were released today.

Actions #11

Updated by Alexis Mousset over 2 years ago

  • Priority changed from 101 to 85
Actions

Also available in: Atom PDF