Project

General

Profile

Actions
Copy link

Architecture #18242

closed

Remove duplicate package_module in ncf

Added by Benoît PECCATTE over 4 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
Félix DALLIDET
Category:
Generic methods
Target version:
6.2.0~beta1
Pull Request:
https://github.com/Normation/ncf/pull...
Effort required:
Name check:
To do
Fix check:
To do
Regression:

Description

Identical package_modules are duplicated in the stdlib.
We modify them n times because we have a custom version.
And it is a pain to update stdlib.
Let's just define our own and use it.

Actions
Copy link
 #1

Updated by Benoît PECCATTE over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE
Actions
Copy link
 #2

Updated by Benoît PECCATTE over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Félix DALLIDET
  • Pull Request set to https://github.com/Normation/ncf/pull/1241
Actions
Copy link
 #3

Updated by Benoît PECCATTE over 4 years ago

  • Status changed from Pending technical review to Rejected

This cannot works, we'll let the duplicated code here

Actions
Copy link
 #4

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods - Package Management to Generic methods
Actions
Copy link

Also available in: Atom PDF