Bug #18377: Duplicated code from a merge #16513 - Rudder - Issue Tracker

Actions

Copy link

Bug #18377

closed

Duplicated code from a merge #16513

Added by François ARMAND about 4 years ago. Updated about 4 years ago.

Status:

Released

Priority:

N/A

Assignee:

Nicolas CHARLES

Category:

Architecture - Code maintenance

Target version:

6.1.6

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Reviewed

Fix check:

Checked

Regression:

Description

We have that code in PolicyWritterService:

...
      readTemplateTime1    <- currentTimeMillis
      configAndPaths       <- calculatePathsForNodeConfigurations(interestingNodeConfigs, rootNodeId, allNodeInfos, newPostfix, backupPostfix)
      pathsInfo            =  configAndPaths.map { _.paths }

      configAndPaths   <- calculatePathsForNodeConfigurations(interestingNodeConfigs, rootNodeId, allNodeInfos, newPostfix, backupPostfix)
      pathsInfo        =  configAndPaths.map { _.paths }
...

That doesn't break by some ghosting magic, but it's really spending resources for nothing.