Bug #18420
closed
saving imported techniques with unknown GM fails with no error prompt
Description
Trying with a 6.2 centos8 build (updated from 6.1), importing a json technique works but the save button does not save the technique plus no error is prompted to the user
Reproduce:
- export a technique,
- change it' name/bundle name,
- change a gneeric method name so that it's a name that doesn't exist
- import.
We need to be MUCH more resilient to such error.
Files
Updated by Gaëtan POBLON over 3 years ago
it appears the technique was legitimately erroing wince the name of a generic method was different. No error was prompted though.
Updated by Gaëtan POBLON over 3 years ago
looks like it creates another issue:
Even in case of errors the Technique Editor seems to occasionally create a technique_name folder that only contains the technique.cf file (and rudder report), making impossible to save a technique with thie same name afterwards. And because it has no .json, it doesnt appear in the techniques list
Updated by Vincent MEMBRÉ over 3 years ago
- Target version changed from 6.2.0~beta1 to 6.2.0~rc1
Updated by François ARMAND over 3 years ago
- Status changed from New to In progress
- Assignee changed from Raphael GAUTHIER to François ARMAND
Updated by François ARMAND over 3 years ago
- File clipboard-202011201908-dvpkk.png clipboard-202011201908-dvpkk.png added
- Subject changed from saving imported techniques fails with no error prompt to saving imported techniques with unknown GM fails with no error prompt
- Description updated (diff)
Doing import of a bad gm, I have hundreds of errors like:
Updated by François ARMAND over 3 years ago
The use case is not that standard, I won't mark it as blocking for 6.2 - especially if the problem is oldert than that and should be correted in 6.1
Updated by François ARMAND over 3 years ago
- Status changed from In progress to New
Updated by Elaad FURREEDAN over 3 years ago
- Status changed from New to In progress
- Assignee set to Elaad FURREEDAN
Updated by Vincent MEMBRÉ over 3 years ago
- Target version changed from 6.2.0~rc1 to 6.2.0
Updated by Elaad FURREEDAN over 3 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Elaad FURREEDAN to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/3431
Updated by Vincent MEMBRÉ over 3 years ago
- Target version changed from 6.2.0 to 6.2.1
Updated by Anonymous over 3 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|06354257a74108de51abc77a366c15699b9e8e3f.
Updated by François ARMAND over 3 years ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ over 3 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 6.2.1 which was released today.