Project

General

Profile

Actions

Architecture #18433

closed

Do not fix component key in generic methods reporting

Added by Benoît PECCATTE about 4 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Effort required:
Name check:
To do
Fix check:
Checked
Regression:

Description

In generic methods reporting, the second parameter of _log_v3 is the component key used for reporting.

This value is already in the reporting context and it is the context version that is used by default if this value is empty.

The value from the reporting context is the one used to report NAs

To make it consistent, and less error prone we could just replace it by "" in each generic method.
Moreover, this would permit customization of component key, which is especially useful in hand made techniques.


Related issues 1 (0 open1 closed)

Related to Rudder - User story #18434: Implement ips package repositories techniqueReleasedAlexis MoussetActions
Actions #1

Updated by Benoît PECCATTE about 4 years ago

Actions #2

Updated by Benoît PECCATTE about 4 years ago

  • Target version set to 6.2.0~beta1
Actions #3

Updated by Benoît PECCATTE about 4 years ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE
Actions #4

Updated by Benoît PECCATTE about 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/1251
Actions #5

Updated by Benoît PECCATTE about 4 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:ef8d84c541830730d37993fb79bbc7adc062519a.

Actions #6

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.2.0~beta1 which was released today.

Actions #7

Updated by Nicolas CHARLES about 4 years ago

  • Fix check changed from To do to Checked
Actions #8

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF