Project

General

Custom queries

Profile

Actions
Copy link

User story #1848

closed

Escape special characters like ' " or ! in directive values

Added by Nicolas PERRON over 13 years ago. Updated over 12 years ago.

Status:
Rejected
Priority:
3
Assignee:
-
Category:
Web - Config management
Target version:
Ideas (not version specific)
Pull Request:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

I kept breaking my Rudder by setting a MOTD with double quotes in. We added a regex validator like "([^"]|(?<=\\)")*" to one PT to disallow quotes unless they're escaped, but it's a bit of a hack...

In a more global frame, this should probably be applied automatically to almost all input passed to CFEngine...

Related issues 4 (0 open — 4 closed)

Related to Rudder - Bug #2170: MOTD PT should validate the MOTD value with a regexReleasedMatthieu CERDA2012-01-12Actions
Related to Rudder - Bug #3108: break rules generation using quotes in a "File content" in a directive like "Enforce a file content"RejectedMatthieu CERDA2012-12-27Actions
Related to Rudder - User story #2887: Add a warning in the checkGenericFileContent Technique about quotesReleasedMatthieu CERDA2012-09-10Actions
Has duplicate Rudder - Bug #2823: Some special characters seems to not be escaped in MOTD TechniqueRejected2012-08-17Actions
Actions
Copy link
 #4

Updated by Michael Gliwinski over 12 years ago

I just ran into this in checkGenericFileContent technique.

It appears #2947 is related too.

Actions
Copy link
 #5

Updated by Nicolas CHARLES over 12 years ago

  • Status changed from New to Rejected

I'm rejecting as a duplicated of #2947

Actions
Copy link

Also available in: Atom PDF