Project

General

Profile

Actions

Bug #19173

closed

Won't fix: Incoherent escaping between Technique Editor and Rudder Technique, and unexpected reports or behaviour in 6.X

Added by Nicolas CHARLES over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
N/A
Assignee:
-
Category:
Web - Compliance & node report
Target version:
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Priority:
82
Name check:
To do
Fix check:
To do
Regression:

Description

This issue won't be fixed in Rudder 6.x, as it would break existing installation of Rudder
However, it is fixed in Rudder 7.0, meaning that upgrades from 6.X to 7.0 may break values by escaping string escaped by hand

Using multiple "\" in a class parameter leads to inconsistent behaviour

Technique editor

Number of \ Value File edited State of edition Report State of report
1 /tmp/escapedfilebyfileonlyone\s /tmp/escapedfilebyfileonlyone\s OK /tmp/escapedfilebyfileonlyone\s OK
2 /tmp/escapedfilebyfiletwice\\s /tmp/escapedfilebyfiletwice\s NOK /tmp/escapedfilebyfiletwice\s NOK
3 /tmp/escapedfilebyfile\\\s /tmp/escapedfilebyfile\\s NOK /tmp/escapedfilebyfile\\s NOK

and you get the idea for the rest
There is no escaping here, causing the \\ to be replaced by \
Content in file, or commands is also unescaped, so \\ are replaced by \

Rudder built-in techniques

Used with Technique Check generic file content

Number of \ Value File edited State of edition Report State of report
1 /tmp/file\sonce /tmp/file\sonce OK /tmp/file\sonce OK
2 /tmp/file\\stwice /tmp/file\\stwice OK /tmp/file\\stwice OK
3 /tmp/file\\\sthrice 'file\\\sthrice' OK /tmp/escapedfilebyfile\\\s OK

There is escaping here, with \\ being replaced by \\\\, and so it ends up correct both in the file name and in the report


Subtasks 2 (0 open2 closed)

Bug #19899: Breaking change: correct escaping for technique editor in 7.0ReleasedFrançois ARMANDActions
Bug #19919: Document that escaping is incoherent with the rest in Technique Editor in 6.X, that it is corrected in 7.0, and that's a breaking changeReleasedAlexis MoussetActions
Actions

Also available in: Atom PDF