Project

General

Profile

Actions
Copy link

Bug #19218

closed

backup file are not copied correctly when the destination directory is on another FS

Added by François ARMAND over 3 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Performance and scalability
Target version:
6.1.13
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

When the destination directory of java.nio.files.File.move is not in the same directory, it does not work and should throw an exception. Somehow, betterfiles eats it and we remain with only pain and sorrow.

We need to revert back from #16382 where we tried to improve performance with `java.nio` and visibly failed.

This ticket should:
- use a safer methods (FileUtils) - but still warn that the destination is bad,
- allow to not set a backup path.

Actions
Copy link
 #1

Updated by François ARMAND over 3 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by François ARMAND over 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/3616
Actions
Copy link
 #3

Updated by François ARMAND over 3 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #4

Updated by François ARMAND over 3 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.1.13 and 6.2.7 which were released today.

Actions
Copy link

Also available in: Atom PDF