Project

General

Profile

Actions
Copy link

Bug #19319

closed

When editing files with the technique editor resources manager, newlines at the end of file are trimmed

Added by Vincent MEMBRÉ almost 3 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Raphael GAUTHIER
Category:
Web - Technique editor
Target version:
6.2.13
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Priority:
70
Name check:
To do
Fix check:
Checked
Regression:

Description

If we want to add newlines at the end of a file in a ressource from the technique editor, theses lines a trimmed resulting in a file different from what we savec

Files

empty-line.png (55.6 KB) empty-line.png Raphael GAUTHIER, 2022-03-10 16:48
Actions
Copy link
 #2

Updated by Elaad FURREEDAN almost 3 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Priority changed from 0 to 51
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.2.8 to 6.2.9
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.2.9 to 6.2.10
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.2.10 to 6.2.11
  • Priority changed from 51 to 50
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.2.11 to 6.2.12
  • Priority changed from 50 to 48
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.2.12 to 6.2.13
  • Priority changed from 48 to 47
Actions
Copy link
 #8

Updated by Elaad FURREEDAN over 2 years ago

  • Translation missing: en.field_tag_list set to Sponsored
  • Priority changed from 47 to 76
Actions
Copy link
 #9

Updated by Raphael GAUTHIER about 2 years ago

  • Status changed from New to In progress
  • Assignee set to Raphael GAUTHIER
  • Priority changed from 76 to 73
Actions
Copy link
 #10

Updated by Raphael GAUTHIER about 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Raphael GAUTHIER to Elaad FURREEDAN
  • Pull Request set to https://github.com/Normation/rudder/pull/4205
Actions
Copy link
 #11

Updated by Raphael GAUTHIER about 2 years ago

By default, AngularJS trims inputs value. This has been fixed by preventing AngularJS from doing this.

There is still one case to fix: if the last line of the file is empty, it is not interpreted when retrieving the contents of the file.

Actions
Copy link
 #12

Updated by Elaad FURREEDAN about 2 years ago

  • Assignee changed from Elaad FURREEDAN to Raphael GAUTHIER
Actions
Copy link
 #13

Updated by Raphael GAUTHIER about 2 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #14

Updated by Nicolas CHARLES about 2 years ago

  • Priority changed from 73 to 72
  • Fix check changed from To do to Checked
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 2 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.2.13, 7.0.2 and 7.1.0~rc1 which were released today.

Actions
Copy link
 #16

Updated by Alexis Mousset almost 2 years ago

  • Priority changed from 72 to 70
Actions
Copy link

Also available in: Atom PDF