Project

General

Profile

Actions

Bug #19431

closed

Invalid reporting in file content technique

Added by Nicolas CHARLES almost 3 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

If we enable line deletion, with a regex matching the line we add, then the directive pretends that the file was ok even if not, and misses the report about line deletion

Actions #1

Updated by Nicolas CHARLES almost 3 years ago

Half of the bug (no report on deletion) is that we define class file_content_deletion and use for reporting content_deletion
Other half is that we have already the line we want in the file, so we define file_content_${index}_success, and SOMEHOW it is used to say that it is compliant

Actions #2

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from New to In progress
Actions #3

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1674
Actions #4

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by Alexis Mousset over 2 years ago

  • Fix check changed from To do to Checked
Actions #6

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.1.14 and 6.2.8 which were released today.

Actions

Also available in: Atom PDF