Project

General

Profile

Actions
Copy link

Bug #19467

closed

Inefficient comparision of strings in Rudder

Added by Nicolas CHARLES over 3 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Performance and scalability
Target version:
6.1.14
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

We are sometimes doing

    val lower = s.toLowerCase
    for(comp <- comparators) {
      if(lower == comp.id.toLowerCase)

rather than

for(comp <- comparators) {
if(name.equalsIgnoreCase(c.name))

it's not that bad, but toLowerCase creates a new object (and toLowerCase or toUpperCase may have unpredictable results for some alphabets)

Actions
Copy link
 #1

Updated by Nicolas CHARLES over 3 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by Nicolas CHARLES over 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3688
Actions
Copy link
 #3

Updated by Nicolas CHARLES over 3 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #4

Updated by François ARMAND over 3 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.1.14 and 6.2.8 which were released today.

Actions
Copy link

Also available in: Atom PDF