Project

General

Profile

Actions

Bug #19865

closed

Technique editor allows empty technique name

Added by Félix DALLIDET 9 months ago. Updated 8 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Technique editor
Target version:
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Small
Priority:
109

Description

In 7.0.0~beta1 I was able to create a technique via the technique editor without setting its name. This was forbidden in prior versions.
It resulted in a technique in the wrong folder:

root@server:/var/rudder/configuration-repository/techniques/ncf_techniques# tree /var/rudder/configuration-repository/techniques/ncf_techniques/1.0/
/var/rudder/configuration-repository/techniques/ncf_techniques/1.0/
├── metadata.xml
├── rudder_reporting.cf
├── technique.cf
├── technique.json
├── technique.ps1
└── technique.rd

0 directories, 6 files

Here is the json of the technique:

{
  "bundle_name":"",
  "version":"1.0",
  "category":"ncf_techniques",
  "description":"",
  "name":"",
  "method_calls":[
    {
      "condition":"my_condition",
      "component":"My bigger block",
      "reportingLogic":{
        "type":"worst" 
      },
      "calls":[
        {
          "condition":"abcd",
          "component":"My inner block",
          "reportingLogic":{
            "type":"sum" 
          },
          "calls":[],
          "id":"565097b9-f3e7-469f-b397-2d0e4e4d60b9" 
        }
      ],
      "id":"757dc295-5739-4e5c-ad72-ae7587cf675f" 
    }
  ],
  "parameter":[],
  "resources":[]
}


Related issues

Related to Rudder - Bug #16135: We can save a technique with empty name when we add a resourceReleasedRaphael GAUTHIERActions
Related to Rudder - Bug #19930: We were able to save a technique without a name which caused chaos NewActions
Actions #1

Updated by Elaad FURREEDAN 9 months ago

  • Status changed from New to In progress
  • Assignee set to Elaad FURREEDAN
Actions #2

Updated by Elaad FURREEDAN 9 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Elaad FURREEDAN to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/3852
Actions #3

Updated by Anonymous 9 months ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by François ARMAND 8 months ago

  • Related to Bug #16135: We can save a technique with empty name when we add a resource added
Actions #5

Updated by François ARMAND 8 months ago

  • Related to Bug #19930: We were able to save a technique without a name which caused chaos added
Actions #6

Updated by Vincent MEMBRÉ 8 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.0.0~beta1 which was released today.

Actions

Also available in: Atom PDF