Project

General

Profile

Actions

Bug #20003

closed

Technique library may not be correctly reloaded when git commit happens when rudder is stopped

Added by François ARMAND over 2 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

We have a case where technique library may not be correctly reloaded if a git commit happened when rudder was stopped.

In that case, we can have the "reload technique lib", which update the current commit known by rudder, that happens before the callback that updates LDAP is registered.
We miss the callback, and then the lib seems to be up to date, but it is not.

Workaround: make a trivial change in all technques that were modified while rudder was stopped, commit, reload technique library.

Dev info: the problem is that `TechniqueAcceptationUpdater` is registered far away from the initialisation of the technique repository, and the git commit (provided by GitTechniqueVersionProvider) is already read and updated by that time. TechniqueRepository tells to noone "this is all the changes".

Actions

Also available in: Atom PDF