Project

General

Profile

Actions

Bug #20071

closed

Compliance incorrectly computed when two components have the same name and cfe vars are involved

Added by François ARMAND over 1 year ago. Updated 10 months ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Web - Compliance & node report
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Priority:
30
Regression:

Description

This is related to #19990 but perhaps it's older than that.

In the case when we have two components with the same name, and at least one of them has a cfengine variable, and all returned report values could match the variable, we count all matching cases for the variable, not removing the value from the other component.
We know that with current structure, it's undecidable in general case (typically, if there is two cfengine vars that convert to a .* pattern), but here, we don't do the pairing that is tried in the old 6.2 cases (in recPairReports).

Example:

Expected reports: 
- block1: "componentXXX", expected value: "${loop}" 
- block2: "componentXXX", expected value: "inBlock2" 

Reports: 
- "componentXXX", "loop1", success
- "componentXXX", "loop2", success
- "componentXXX", "loop3", success
- "componentXXX", "inBlock2", error

In that case, componentXXX in block2 will have its correct value with status error.
But componentXXX in block1 will ALSO have status error with 4 reports, its own three loops and the one for blocks2.

Workaround

The workaround is easy: change the name for one of the component.

Correction

The only correct and definitive solution for that problem is to give each reprots an unique ID in expected reports and use that in compliance computation.


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #19990: Technique editor blocks do not report as expectedReleasedFrançois ARMANDActions
Actions #1

Updated by François ARMAND over 1 year ago

  • Related to Bug #19990: Technique editor blocks do not report as expected added
Actions #2

Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 7.1.0~beta1 to 7.1.0~beta2
  • Priority changed from 16 to 30
Actions #3

Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 7.1.0~beta2 to 7.1.0~rc1
Actions #4

Updated by Alexis Mousset 10 months ago

  • Status changed from New to Rejected

This part has changed significantly in 7.1

Actions

Also available in: Atom PDF