Project

General

Profile

Actions

Bug #20341

closed

Empty value for certificate should not kill rudder

Added by François ARMAND 6 months ago. Updated 5 months ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Refactoring
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

We have an assert in Certificate and PublicKey object in webapp/sources/ldap-inventory/inventory-api/src/main/scala/com/normation/inventory/domain/DataTypes.scala.

When, for some unknown reason, that data is empty, it kills rudder (see #20338). This is not what should be done. We should take care of the fact, and return an error to the caller.

I'm not sure how the bad data reached that point, but it should not be handled like that. On the other hand, the guard worked as expected, and the error was spotted quickly.
(I suspect that a node info cache update was triggered in the middle of the node creation, and so the certificate data were not present, but not sure).

I propose to change only in 7.0.

Actions #1

Updated by François ARMAND 6 months ago

  • Description updated (diff)
Actions #2

Updated by François ARMAND 6 months ago

  • Status changed from New to In progress
Actions #3

Updated by François ARMAND 6 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4030
Actions #4

Updated by François ARMAND 6 months ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by Vincent MEMBRÉ 5 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.0.0~rc2 which was released today.

Actions

Also available in: Atom PDF