Project

General

Profile

Actions
Copy link

Bug #2170

closed

MOTD PT should validate the MOTD value with a regex

Added by Jonathan CLARKE over 12 years ago. Updated about 9 years ago.

Status:
Released
Priority:
3
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
2.3.7
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I keep breaking my Rudder by setting a MOTD with double quotes in.

Could we add a regex validator like "([^"]|(?<=\\)")*" ? This would disallow quotes unless they're escaped.

In a more global frame, this should probably be applied automatically to almost all input passed to CFEngine...

Related issues 1 (0 open — 1 closed)

Related to Rudder - User story #1848: Escape special characters like ' " or ! in directive valuesRejected2011-09-26Actions
Actions
Copy link
 #1

Updated by Matthieu CERDA over 12 years ago

"Yes, we can !"

Actions
Copy link
 #2

Updated by Matthieu CERDA over 12 years ago

  • Status changed from 2 to In progress
  • Assignee set to Matthieu CERDA
Actions
Copy link
 #3

Updated by Matthieu CERDA over 12 years ago

  • Estimated time set to 0.25 h
Actions
Copy link
 #4

Updated by Jonathan CLARKE about 12 years ago

  • Target version changed from 2.3.6 to 2.3.7
Actions
Copy link
 #5

Updated by Matthieu CERDA about 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:c0df09b43c59584ac8f3f4542dad246ba9b6a8e5.

Actions
Copy link
 #6

Updated by Anonymous about 12 years ago

Applied in changeset commit:08386023b4a6a0b8496e333c3b6db79bf26e9cbf.

Actions
Copy link
 #7

Updated by Matthieu CERDA about 12 years ago

I'm the Anonymous guy.

Actions
Copy link
 #8

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to Released

Looks good to me!

Actions
Copy link
 #9

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 24 to Rudder
  • Category changed from Policy Templates to Techniques
Actions
Copy link

Also available in: Atom PDF