Project

General

Profile

Actions

Enhancement #21931

closed

Display the list of pending change requests related to the selected rule

Added by Elaad FURREEDAN over 1 year ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Web - UI & UX
Target version:
UX impact:
I dislike using that feature
Suggestion strength:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Large
Name check:
To do
Fix check:
Checked
Regression:
Yes

Description

Change request in rule's page are managed very badly. It's hard to know what happen when we try to edit a rule with the plugin change request enable.
This is a regression since we port the page in Elm in 7.0

Currently

When change request plugin is enabled, if we edit a rule, a change request is generated, but we don't have any information on the rule that there is a pending CR.
We have a success notification, we can see for example that the title of the rule change, but not in the tree. In fact nothing has changed, but the notification misleads us.

What we can do

We can take the operation in Group's page:
  • Display a message on top to see all CR pending to the rule
  • Do not update any information on save
  • No notification on save

Files

rule_no_CR_popup.gif (267 KB) rule_no_CR_popup.gif Elaad FURREEDAN, 2022-10-07 16:20
clipboard-202210071624-z8tqz.png (357 KB) clipboard-202210071624-z8tqz.png Elaad FURREEDAN, 2022-10-07 16:25

Subtasks 2 (0 open2 closed)

Bug #24082: Missing title for pending change request in rule pageReleasedElaad FURREEDANActions
Enhancement #24088: Don't do REST call if change request plugin is not enabledReleasedVincent MEMBRÉActions

Related issues 5 (0 open5 closed)

Related to Rudder - Bug #22895: When adding a directive to a rule we cannot add event log anymoreResolvedRaphael GAUTHIERActions
Related to Rudder - Bug #23372: Add a way to set a message if "change audit logs" setting is enabledReleasedRaphael GAUTHIERActions
Related to Rudder plugins - Enhancement #23907: List change requests with additional filtersReleasedFrançois ARMANDActions
Related to Rudder - Bug #24079: Fix small ui error in the rules information tabReleasedVincent MEMBRÉActions
Has duplicate Rudder - Enhancement #23676: Display the list of pending change requests related to the selected ruleRejectedRaphael GAUTHIERActions
Actions #1

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.1.7 to 7.1.8
Actions #2

Updated by François ARMAND over 1 year ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Priority changed from 0 to 64
Actions #3

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.1.8 to 7.1.9
  • Priority changed from 64 to 63
Actions #4

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.1.9 to 7.1.10
  • Priority changed from 63 to 62
Actions #5

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.1.10 to 1016
  • Priority changed from 62 to 61
Actions #6

Updated by François ARMAND over 1 year ago

  • Target version changed from 1016 to 7.2.5
Actions #7

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.2.5 to 7.2.6
  • Priority changed from 61 to 59
Actions #8

Updated by Elaad FURREEDAN about 1 year ago

  • Effort required changed from Medium to Large
  • Priority changed from 59 to 47
Actions #9

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.2.6 to 7.2.7
  • Priority changed from 47 to 46
Actions #10

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.2.7 to 7.2.8
Actions #11

Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 7.2.8 to 7.2.9
  • Priority changed from 46 to 44
Actions #12

Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 7.2.9 to 7.2.10
Actions #13

Updated by Alexis Mousset 10 months ago

  • Target version changed from 7.2.10 to 7.2.11
  • Priority changed from 44 to 43
Actions #14

Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 7.2.11 to 1046
  • Priority changed from 43 to 42
Actions #15

Updated by Raphael GAUTHIER 8 months ago

  • Subject changed from Missing integration of change request in rule page to Display the list of pending change requests related to the selected rule
Actions #16

Updated by Raphael GAUTHIER 8 months ago

  • Target version changed from 1046 to 7.3.8
Actions #17

Updated by François ARMAND 7 months ago

  • Related to Bug #22895: When adding a directive to a rule we cannot add event log anymore added
  • Related to Bug #23372: Add a way to set a message if "change audit logs" setting is enabled added
Actions #18

Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 7.3.8 to 7.3.9
Actions #19

Updated by Raphael GAUTHIER 7 months ago

  • Has duplicate Enhancement #23676: Display the list of pending change requests related to the selected rule added
Actions #20

Updated by Raphael GAUTHIER 7 months ago

  • Tracker changed from Bug to Enhancement
  • Severity deleted (Minor - inconvenience | misleading | easy workaround)
  • Priority deleted (42)
Actions #21

Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 7.3.9 to 7.3.10
Actions #22

Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 7.3.10 to 7.3.11
Actions #23

Updated by Raphael GAUTHIER 5 months ago

  • Target version changed from 7.3.11 to 8.0.5
Actions #24

Updated by Raphael GAUTHIER 5 months ago

  • Status changed from New to In progress
  • Assignee set to Raphael GAUTHIER
Actions #25

Updated by Clark ANDRIANASOLO 5 months ago

Actions #28

Updated by Raphael GAUTHIER 5 months ago

  • Target version changed from 8.0.5 to 7.3.11
Actions #30

Updated by Raphael GAUTHIER 4 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5330
Actions #31

Updated by Raphael GAUTHIER 4 months ago

  • Status changed from Pending technical review to Pending release
Actions #32

Updated by Raphael GAUTHIER 4 months ago

  • Related to Bug #24079: Fix small ui error in the rules information tab added
Actions #33

Updated by Elaad FURREEDAN 4 months ago

  • Related to Bug #24082: Missing title for pending change request in rule page added
Actions #34

Updated by Elaad FURREEDAN 4 months ago

  • Fix check changed from To do to Error - Blocking
Actions #35

Updated by François ARMAND 4 months ago

  • Subtask #24088 added
Actions #36

Updated by Vincent MEMBRÉ 4 months ago

  • Related to deleted (Bug #24082: Missing title for pending change request in rule page)
Actions #37

Updated by Vincent MEMBRÉ 4 months ago

  • Subtask #24082 added
Actions #38

Updated by Clark ANDRIANASOLO 4 months ago

  • Fix check changed from Error - Blocking to Checked
Actions #39

Updated by Vincent MEMBRÉ 4 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.3.11 which was released today.

Actions

Also available in: Atom PDF