Bug #22129
closed
Id to start looking for report json should not be zero but highest id causing abysmal performance on postgresql
Added by Vincent MEMBRÉ almost 2 years ago.
Updated almost 2 years ago.
Description
Since we don't update the starting value when we don't get any report_json, next run will use the same id to check for new reports, but we should use store the highest id in databse instead
- Status changed from New to In progress
- Assignee set to Vincent MEMBRÉ
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/4582
- Status changed from Pending technical review to Pending release
- Fix check changed from To do to Error - Blocking
The current implementation makes the counter update once and then it never get updated again:
# rudder is shut down
rudder=> select * from rudderproperties ;
name | value
---------------------+-------
reportHandlerLastId | 22287
reportLoggerLastId | 23032
(2 rows)
# rudder starts ...
rudder=> select * from rudderproperties ;
name | value
---------------------+-------
reportLoggerLastId | 23032
reportHandlerLastId | 23032
(2 rows)
# a run happened
rudder=> select * from rudderproperties ;
name | value
---------------------+-------
reportHandlerLastId | 23032
reportLoggerLastId | 23122
(2 rows)
# an other run happens...
rudder=> select * from rudderproperties ;
name | value
---------------------+-------
reportLoggerLastId | 23371
reportHandlerLastId | 23032
(2 rows)
- Fix check changed from Error - Blocking to Checked
- Status changed from Pending release to Released
This bug has been fixed in Rudder 7.2.2 which was released today.
- Subject changed from Id to start looking for report json should not be zero but highest id. to Id to start looking for report json should not be zero but highest id causing abysmal performance on postgres
- Subject changed from Id to start looking for report json should not be zero but highest id causing abysmal performance on postgres to Id to start looking for report json should not be zero but highest id causing abysmal performance on postgresql
Also available in: Atom
PDF