Project

General

Profile

Actions
Copy link

Bug #22170

closed

A new group display no nodes while all linux are selected

Added by Alexis TARUSSIO almost 2 years ago. Updated 10 months ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Web - UI & UX
Target version:
7.3.11
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
I hate Rudder for that
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Very Small
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No

Description

Hello guys !

I just encounters a massive thing that make me hate both myself AND Rudder.

I create a rule wich deploy PHP / FPM/ etc... This works really fine, and to use it I must create a group and add it to the rule.

And by default when you create a group the criteria take all the node, which happened and I end up with php deploy on half on my infrastructure.

I think it's extremely dangerous when you industrialize massively your Architecture. User is responsible of what he's doing but Rudder should have safe guard.

The idea behind this issue, is to when you create a new group by default no node is add to the group.

best regards,

Alexis TARUSSIO

Files

Download all files
clipboard-202401251753-6cail.png (89.7 KB) clipboard-202401251753-6cail.png François ARMAND, 2024-01-25 17:53
clipboard-202401251757-06mh2.png (21.6 KB) clipboard-202401251757-06mh2.png François ARMAND, 2024-01-25 17:57

Related issues 3 (2 open — 1 closed)

Related to Rudder - Bug #22400: Empty group criteria breaks UI for adding new criteriaNewActions
Related to Rudder - Bug #25820: On new groups, adding a prop leads to "No query defined for group" errorReleasedClark ANDRIANASOLOActions
Related to Rudder - Bug #25026: Groups can be created without any research criteriaNewActions
Actions
Copy link
 #1

Updated by Alexis Mousset almost 2 years ago

  • Category set to Web - UI & UX
  • Target version set to 7.3.0~beta1
  • UX impact set to I hate Rudder for that
  • User visibility set to Infrequent - complex configurations | third party integrations
  • Effort required set to Very Small

This makes a lot of sense.

Actions
Copy link
 #2

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 7.3.0~beta1 to 7.3.0~rc1
Actions
Copy link
 #4

Updated by Elaad FURREEDAN over 1 year ago

In fact, we cannot have empty criteria from the UI

Actions
Copy link
 #5

Updated by Elaad FURREEDAN over 1 year ago

  • Related to Bug #22400: Empty group criteria breaks UI for adding new criteria added
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.0~rc1 to 7.3.0
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.0 to 7.3.1
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.1 to 7.3.2
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.2 to 7.3.3
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.3 to 7.3.4
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.3.4 to 7.3.5
Actions
Copy link
 #12

Updated by Alexis Mousset over 1 year ago

  • Target version changed from 7.3.5 to 7.3.6
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.6 to 7.3.7
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.7 to 7.3.8
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.8 to 7.3.9
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.9 to 7.3.10
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 7.3.10 to 7.3.11
Actions
Copy link
 #18

Updated by François ARMAND 11 months ago

We don't have a simple way to change that apport from changing the default selector for the newly created group.
We could use something like a never validating regex, but I'm not sure it woon't be more surprising.

Actions
Copy link
 #19

Updated by François ARMAND 11 months ago

  • Target version changed from 7.3.11 to 8.1.0~alpha1

We should wait for a major release to change that default behavior.

Actions
Copy link
 #20

Updated by François ARMAND 11 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions
Copy link
 #21

Updated by François ARMAND 11 months ago

  • Status changed from In progress to New
  • Assignee deleted (François ARMAND)
  • Target version changed from 8.1.0~alpha1 to 7.3.11

OK, actually the main problem is that the group is displayed empty at creation until we click on "search" while it is not. So in the first dyn group update, it changes, which is extremely surprising.

Actions
Copy link
 #22

Updated by François ARMAND 11 months ago

  • Tracker changed from Enhancement to Bug
  • Subject changed from Group Criteria to null not to all node to A new group display no nodes while all linux are selected
  • Priority set to 0
Actions
Copy link
 #23

Updated by François ARMAND 11 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions
Copy link
 #24

Updated by François ARMAND 11 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5255
Actions
Copy link
 #25

Updated by Anonymous 11 months ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link Download all files
 #26

Updated by François ARMAND 10 months ago

It now correctly handled:
- when created, the group is saved with an empty selector:

- we really don't have any node for that group:

And then, we can go to group criteria, hit search then save directly to get all linux nodes like before, or actually specify criteria.

Actions
Copy link
 #27

Updated by Vincent MEMBRÉ 10 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.3.11 which was released today.

Actions
Copy link
 #28

Updated by François ARMAND 15 days ago

  • Related to Bug #25820: On new groups, adding a prop leads to "No query defined for group" error added
Actions
Copy link
 #29

Updated by François ARMAND 15 days ago

  • Related to Bug #25026: Groups can be created without any research criteria added
Actions
Copy link

Also available in: Atom PDF