Project

General

Profile

Actions

Bug #22363

closed

User should be able to accept change request even with divergences

Added by François ARMAND about 1 year ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
I hate Rudder for that
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Small
Priority:
114
Name check:
To do
Fix check:
Checked
Regression:
No

Description

When we compare two directive, we are not cleaning up directive parameters of all spaces differences, which lead to merge divergence when the change is for ex a different line break caracter.

Most of the time, we won't care at all, and so we should let the user accept such change requests.

Actually, we should clean-up these one automaticatlly, and still let user accept change request on divergence (he knows better than us what he is doing).

Actions #1

Updated by François ARMAND about 1 year ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #2

Updated by François ARMAND about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4663
Actions #3

Updated by Anonymous about 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Vincent MEMBRÉ about 1 year ago

  • Fix check changed from To do to Checked
Actions #5

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending release to Released
  • Priority changed from 115 to 114

This bug has been fixed in Rudder 7.2.5 which was released today.

Actions

Also available in: Atom PDF