Project

General

Profile

Actions

Bug #22375

closed

Nodes not answering are seen in "missing" rather than in "no reports"

Added by Nicolas CHARLES about 1 year ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Compliance & node report
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
I hate Rudder for that
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Small
Priority:
171
Name check:
To do
Fix check:
Checked
Regression:
Yes

Description

Nodes with litterally no reports are seen in missing in the compliance rather than no reports because their configId is not known

I have already seen this issue (but I can't find the ticket) and to reproduce it, it may a node offline AND policy generation that changes the node config id for its policy (it may or may not be important to have outdated nodeconfigid as well)
The system is in change only reporting, it may or may not be relevant

Step to reproduce:
  • have a node offline
  • that as a last run non empty (doing insert into reportsexecution values ( '13d97019-f5ab-4f1f-8846-fdf36c0a7d45', '2023-01-10 00:00:00+01', '20230111-112830-e13bcefb', 314643008, '2023-01-14 23:00:47.293154', '2023-02-11 23:10:47.293154' ); is enough to create a last run date
  • restart rudder-jetty
  • see that the node is in "missing" (red) rather than "no reports" (grey)

Subtasks 1 (0 open1 closed)

Bug #22381: Add unit test for the missing/unexpected parent issue on old runsReleasedFrançois ARMANDActions

Related issues 2 (0 open2 closed)

Has duplicate Rudder - Bug #19942: reporting states that node sends out of date reports rather than the node sent reports too long agoRejectedActions
Has duplicate Rudder - Bug #15907: Changes-only does not behave as expected and lead to missing reportsRejectedActions
Actions #1

Updated by Nicolas CHARLES about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Nicolas CHARLES about 1 year ago

  • Subject changed from Nodes not answering are seen in error to Nodes not answering are seen in "missing" rather than in "no reports"
  • Description updated (diff)
Actions #4

Updated by Nicolas CHARLES about 1 year ago

i don't really remember the intricates of the code, but it's possible that we are comparing the nodeconfigId before checking if the run is expired, causing this issue

Actions #5

Updated by François ARMAND about 1 year ago

  • Related to Bug #22371: missing report in change only added
Actions #6

Updated by Vincent MEMBRÉ about 1 year ago

It was reported previously as #19942

Actions #7

Updated by Vincent MEMBRÉ about 1 year ago

  • Has duplicate Bug #19942: reporting states that node sends out of date reports rather than the node sent reports too long ago added
Actions #8

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #9

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/4669
Actions #10

Updated by François ARMAND about 1 year ago

  • Related to deleted (Bug #22371: missing report in change only)
Actions #11

Updated by François ARMAND about 1 year ago

  • Has duplicate Bug #22371: missing report in change only added
Actions #12

Updated by François ARMAND about 1 year ago

  • Subtask #22381 added
Actions #13

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #14

Updated by François ARMAND about 1 year ago

  • Has duplicate deleted (Bug #22371: missing report in change only)
Actions #15

Updated by Vincent MEMBRÉ about 1 year ago

  • Has duplicate Bug #15907: Changes-only does not behave as expected and lead to missing reports added
Actions #16

Updated by François ARMAND about 1 year ago

  • Priority changed from 172 to 171
  • Fix check changed from To do to Checked
Actions #17

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.2.5 which was released today.

Actions

Also available in: Atom PDF