Project

General

Profile

Actions

Bug #22456

open

Change json structure returned for /settings/allowed_networks

Added by François ARMAND 10 days ago. Updated 3 days ago.

Status:
Pending technical review
Priority:
N/A
Category:
API
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:
No

Description

We return:

GET api/latest/settings
{
  "action": "getAllSettings",
  "result": "success",
  "data": {
    "settings": {
      "allowed_networks": [
        {
          "id": "root",
          "allowed_networks": [
            "192.168.2.0/24",
            "192.168.4.0/24" 
          ]
        },
        {
          "id": "f13f6726-1fdc-4ddc-9563-186648636ba4",
          "allowed_networks": []
        }
      ],

But then:

GET /latest/settings/allowed_networks
{
  "action": "getAllAllowedNetworks",
  "result": "success",
  "data": {
    "settings": [
      {
        "id": "root",
        "allowed_networks": [
          "192.168.2.0/24",
          "192.168.4.0/24" 
        ]
      },
      {
        "id": "f13f6726-1fdc-4ddc-9563-186648636ba4",
        "allowed_networks": []
      }
    ]
  }
}

People are expecting:

{
  "action": "getAllAllowedNetworks",
  "result": "success",
  "data": {
    "allowed_networks": [
      {
        "id": "root",
 ...

Plus, on modify, one send with "allowed_networks": [... ]

This can be done by keeping one structure in v17/Rudder 7.3 and getting the new one on v18/Rudder 8/0


Related issues 1 (1 open0 closed)

Related to Rudder - Bug #22467: Inconsistency in API doc for allowed networkPending releaseAlexis MoussetActions
Actions #1

Updated by Elaad FURREEDAN 6 days ago

  • Related to Bug #22467: Inconsistency in API doc for allowed network added
Actions #2

Updated by François ARMAND 3 days ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #3

Updated by François ARMAND 3 days ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4706
Actions

Also available in: Atom PDF