Actions
Bug #22456
closedChange json structure returned for /settings/allowed_networks
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No
Description
We return:
GET api/latest/settings { "action": "getAllSettings", "result": "success", "data": { "settings": { "allowed_networks": [ { "id": "root", "allowed_networks": [ "192.168.2.0/24", "192.168.4.0/24" ] }, { "id": "f13f6726-1fdc-4ddc-9563-186648636ba4", "allowed_networks": [] } ],
But then:
GET /latest/settings/allowed_networks { "action": "getAllAllowedNetworks", "result": "success", "data": { "settings": [ { "id": "root", "allowed_networks": [ "192.168.2.0/24", "192.168.4.0/24" ] }, { "id": "f13f6726-1fdc-4ddc-9563-186648636ba4", "allowed_networks": [] } ] } }
People are expecting:
{ "action": "getAllAllowedNetworks", "result": "success", "data": { "allowed_networks": [ { "id": "root", ...
Plus, on modify, one send with "allowed_networks": [... ]
This can be done by keeping one structure in v17/Rudder 7.3 and getting the new one on v18/Rudder 8/0
Updated by Elaad FURREEDAN over 1 year ago
- Related to Bug #22467: Inconsistency in API doc for allowed network added
Updated by François ARMAND over 1 year ago
- Status changed from New to In progress
- Assignee set to François ARMAND
Updated by François ARMAND over 1 year ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/4706
Updated by François ARMAND over 1 year ago
- Related to Bug #22636: Missing "latest" in archive API tests leads to error with upmerge added
Updated by Anonymous over 1 year ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|f526703b4ce2974738731aed463acaaa712dd8c6.
Updated by Vincent MEMBRÉ over 1 year ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 8.0.0~alpha1 which was released today.
Actions