Project

General

Profile

Actions

Bug #22456

closed

Change json structure returned for /settings/allowed_networks

Added by François ARMAND about 1 year ago. Updated 10 months ago.

Status:
Released
Priority:
N/A
Category:
API
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No

Description

We return:

GET api/latest/settings
{
  "action": "getAllSettings",
  "result": "success",
  "data": {
    "settings": {
      "allowed_networks": [
        {
          "id": "root",
          "allowed_networks": [
            "192.168.2.0/24",
            "192.168.4.0/24" 
          ]
        },
        {
          "id": "f13f6726-1fdc-4ddc-9563-186648636ba4",
          "allowed_networks": []
        }
      ],

But then:

GET /latest/settings/allowed_networks
{
  "action": "getAllAllowedNetworks",
  "result": "success",
  "data": {
    "settings": [
      {
        "id": "root",
        "allowed_networks": [
          "192.168.2.0/24",
          "192.168.4.0/24" 
        ]
      },
      {
        "id": "f13f6726-1fdc-4ddc-9563-186648636ba4",
        "allowed_networks": []
      }
    ]
  }
}

People are expecting:

{
  "action": "getAllAllowedNetworks",
  "result": "success",
  "data": {
    "allowed_networks": [
      {
        "id": "root",
 ...

Plus, on modify, one send with "allowed_networks": [... ]

This can be done by keeping one structure in v17/Rudder 7.3 and getting the new one on v18/Rudder 8/0


Related issues 2 (0 open2 closed)

Related to Rudder - Bug #22467: Inconsistency in API doc for allowed networkReleasedAlexis MoussetActions
Related to Rudder - Bug #22636: Missing "latest" in archive API tests leads to error with upmergeReleasedAlexis MoussetActions
Actions

Also available in: Atom PDF