Bug #22525: Directives applied twice don't show in rule details (they should be skipped) - Rudder - Issue Tracker

Custom queries

Bugs triage
CS - by Assignee
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #22525

closed

Directives applied twice don't show in rule details (they should be skipped)

Added by Nicolas CHARLES over 2 years ago. Updated about 1 year ago.

Status:

Released

Priority:

N/A

Assignee:

Elaad FURREEDAN

Category:

Web - Compliance & node report

Target version:

7.3.14

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

It bothers me each time

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Priority:

Name check:

To do

Fix check:

Checked

Regression:

Yes

Description

but it does appears as skipped on the node compliance page

in the rule page: per directive nothing

per node nothing

Files

Download all files

clipboard-202303231725-lmhyd.png (64.2 KB) clipboard-202303231725-lmhyd.png		Nicolas CHARLES, 2023-03-23 17:25
clipboard-202303231727-slfpe.png (64.7 KB) clipboard-202303231727-slfpe.png		Nicolas CHARLES, 2023-03-23 17:27
clipboard-202303231727-6tyrs.png (37.4 KB) clipboard-202303231727-6tyrs.png		Nicolas CHARLES, 2023-03-23 17:27

Related issues 4 (1 open — 3 closed)

Related to Rudder - Bug #18931: No skipped directives on Rule screen after parent ticket	Released	Nicolas CHARLES	Actions
Related to Rudder - Bug #15125: Rule shown as "Mixed" whereas applied to one audit node and one (skipped) enforce directive	New		Actions
Related to Rudder - Architecture #23656: Rewrite Nodes compliance table in Elm	Released	Vincent MEMBRÉ	Actions
Related to Rudder - Bug #24097: Skipped directive does not show in node compliance tree	Released	François ARMAND	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Vincent MEMBRÉ about 2 years ago

Target version changed from 7.2.6 to 7.2.7

Actions

Copy link

Updated by Vincent MEMBRÉ about 2 years ago

Target version changed from 7.2.7 to 7.2.8

Actions

Copy link

Updated by Nicolas CHARLES about 2 years ago

Regression changed from No to Yes

Actions

Copy link

Updated by François ARMAND about 2 years ago

Severity set to Minor - inconvenience | misleading | easy workaround
UX impact set to It bothers me each time
User visibility set to Operational - other Techniques | Rudder settings | Plugins
Priority changed from 0 to 99

Actions

Copy link

Updated by Elaad FURREEDAN about 2 years ago

Status changed from New to In progress
Assignee set to Elaad FURREEDAN

Actions

Copy link

Updated by Nicolas CHARLES about 2 years ago

Related to Bug #18931: No skipped directives on Rule screen after parent ticket added

Actions

Copy link

Updated by Vincent MEMBRÉ about 2 years ago

Target version changed from 7.2.8 to 7.2.9
Priority changed from 99 to 97

Actions

Copy link

Updated by Vincent MEMBRÉ almost 2 years ago

Target version changed from 7.2.9 to 7.2.10
Priority changed from 97 to 96

Actions

Copy link

#10

Updated by Alexis Mousset almost 2 years ago

Target version changed from 7.2.10 to 7.2.11
Priority changed from 96 to 95

Actions

Copy link

#11

Updated by Vincent MEMBRÉ almost 2 years ago

Target version changed from 7.2.11 to 1046
Priority changed from 95 to 93

Actions

Copy link

#12

Updated by Alexis Mousset over 1 year ago

Target version changed from 1046 to 7.3.8
Priority changed from 93 to 92

Actions

Copy link

#13

Updated by Elaad FURREEDAN over 1 year ago

Priority changed from 92 to 91

Work in progess here: https://github.com/ElaadF/rudder/commit/c64c6dced693d14b9e5a3912132266feef98ed19

Actions

Copy link

#14

Updated by Elaad FURREEDAN over 1 year ago

Status changed from In progress to Pending technical review
Assignee changed from Elaad FURREEDAN to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder/pull/5132

PR https://github.com/Normation/rudder/pull/5132

Actions

Copy link

#15

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.8 to 7.3.9

Actions

Copy link

#16

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.9 to 7.3.10

Actions

Copy link

#17

Updated by François ARMAND over 1 year ago

Related to Bug #15125: Rule shown as "Mixed" whereas applied to one audit node and one (skipped) enforce directive added

Actions

Copy link

#18

Updated by Elaad FURREEDAN over 1 year ago

Status changed from Pending technical review to In progress
Assignee changed from Nicolas CHARLES to Elaad FURREEDAN
Priority changed from 91 to 90

I'm taking over this issue!

Actions

Copy link

#19

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.10 to 7.3.11
Priority changed from 90 to 89

Actions

Copy link

#20

Updated by Clark ANDRIANASOLO over 1 year ago

Assignee changed from Elaad FURREEDAN to Nicolas CHARLES
Priority changed from 89 to 87

Actions

Copy link

#21

Updated by Clark ANDRIANASOLO over 1 year ago

Assignee changed from Nicolas CHARLES to Elaad FURREEDAN

Actions

Copy link

#22

Updated by Clark ANDRIANASOLO over 1 year ago

Priority changed from 87 to 86

The rules page was rewritten from Lift in Scala to Elm + Scala API and we lost the "skipped" information on the API side.
We need to :

add the information to the current API endpoint whenever the directive is skipped (ideally also all other API endpoints for compliance)
display the skipped badge from this information

Actions

Copy link

#23

Updated by Clark ANDRIANASOLO over 1 year ago

Related to Architecture #23656: Rewrite Nodes compliance table in Elm added

Actions

Copy link

#24

Updated by Clark ANDRIANASOLO over 1 year ago

(Note : in 7.3 the node compliance tree shows the "skipped" badge, but it has also been rewritten in Elm since 8.0 in the issue https://issues.rudder.io/issues/23656 where it disappears)

Actions

Copy link

#25

Updated by Clark ANDRIANASOLO over 1 year ago

Assignee changed from Elaad FURREEDAN to Clark ANDRIANASOLO

Actions

Copy link

#26

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.11 to 7.3.12

Actions

Copy link

#27

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.12 to 7.3.13
Priority changed from 86 to 85

Actions

Copy link

#28

Updated by Vincent MEMBRÉ over 1 year ago

Target version changed from 7.3.13 to 7.3.14
Priority changed from 85 to 84

Actions

Copy link

#29

Updated by Clark ANDRIANASOLO over 1 year ago

Work in progess here: https://github.com/clarktsiory/rudder/commit/43da87232414f2e0698f97f781546d298403095f

Actions

Copy link

#30

Updated by Clark ANDRIANASOLO about 1 year ago

Work in progess here: https://github.com/clarktsiory/rudder/commit/f805f0e1c4fe659650ce5ffe7547622a136ee96f

Actions

Copy link

#31

Updated by Clark ANDRIANASOLO about 1 year ago

Work in progess here: https://github.com/clarktsiory/rudder/commit/a6da78b91bd441e3fb3c1c46e0eb3ef47c4870fd

Actions

Copy link

#32

Updated by Clark ANDRIANASOLO about 1 year ago

Status changed from In progress to Pending technical review
Assignee changed from Clark ANDRIANASOLO to François ARMAND
Pull Request changed from https://github.com/Normation/rudder/pull/5132 to https://github.com/Normation/rudder/pull/5600

PR https://github.com/Normation/rudder/pull/5600

Actions

Copy link

#33