Actions
Architecture #2279
closed
Shoud we use the TreeWalk.release() method after walking the JGit tree ?
Status:
Rejected
Priority:
4
Assignee:
-
Category:
Architecture - Code maintenance
Target version:
Pull Request:
Effort required:
Name check:
Fix check:
Regression:
Description
The documentation is a bit unclear about the subject; it states clearly that RevWalk should be released after use ( http://wiki.eclipse.org/JGit/User_Guide ) but doesn't state the same for the TreeWalk (actually, it says nothing)
However, there is a release method in this class, so it is interesting to see if it should be invoked
Updated by Jonathan CLARKE almost 13 years ago
- Category changed from 13 to Architecture - Code maintenance
- Assignee changed from Jonathan CLARKE to François ARMAND
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 2.4.0~alpha6 to 2.4.0~alpha7
Updated by François ARMAND over 12 years ago
- Assignee deleted (
François ARMAND) - Target version changed from 2.4.0~alpha7 to 24
Not the kind of code modification we want to handle know, I thing.
I does not seems to leak as it is, so perhaps we shall think to it again in 2.5 ?
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 24 to Ideas (not version specific)
Updated by Nicolas CHARLES over 4 years ago
- Status changed from New to Rejected
I guess it can be safely rejected: it's been working for 8 years, should still be ok
Actions