Project

General

Profile

Actions

Bug #22978

closed

Cache most current Version number to save lots of memory

Added by François ARMAND over 1 year ago. Updated over 1 year ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Code maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No

Description

We have a version object used in several part of rudder (for os version, packages, etc) - several time by node.
If we cache the N (50 ? 100?) first integer, we save a lot of space (more once everything node related will be in nodefact, but already a bit).

It doesn't change anything in the Version API, parsing, etc. Just reuse common number in place of creating lots of short lived objects.


Files

clipboard-202307201553-urpvk.png (47.4 KB) clipboard-202307201553-urpvk.png François ARMAND, 2023-07-20 15:53

Related issues 1 (1 open0 closed)

Related to Rudder - Architecture #22672: Remove node information and inventories from LDAPPending technical reviewVincent MEMBRÉActions
Actions #1

Updated by François ARMAND over 1 year ago

Actions #2

Updated by François ARMAND over 1 year ago

  • Status changed from New to In progress
Actions #3

Updated by François ARMAND over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4858
Actions #4

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.8 to 7.2.9
Actions #5

Updated by Anonymous over 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #6

Updated by François ARMAND over 1 year ago

Checked that technique versions are still ok, nothing seems to be strange.
Mem dump shows that only 100 instance are created in a standard rudder, so we should be good.

Actions #7

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.2.9 and 7.3.4 which were released today.

Actions

Also available in: Atom PDF