Actions
Bug #23332
closed
Serde errors do not point to the correct line number
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No
Description
Due to the way items are deserialized.
The other problem is that higher level diagnostics can't refer to a source line.
No simple fix:
- https://github.com/dtolnay/serde-yaml/issues/128
- https://github.com/faradayio/openapi-interfaces/issues/28
Leads:
- Patch in https://github.com/chyh1990/yaml-rust/issues/103
- And for source markers https://github.com/chyh1990/yaml-rust/pull/125
We can start with a simple solution, which it to deserialize into a simpler structure to handle basic stuff, and then convert to the actual technique and manually handle errors.
Updated by Alexis Mousset over 1 year ago
- Status changed from New to In progress
- Assignee set to Alexis Mousset
Updated by Vincent MEMBRÉ over 1 year ago
- Target version changed from 8.0.0~beta1 to 8.0.0~beta2
Updated by Vincent MEMBRÉ over 1 year ago
- Target version changed from 8.0.0~beta2 to 8.0.0~beta3
Updated by Alexis Mousset about 1 year ago
- Target version changed from 8.0.0~beta3 to 8.1.0~alpha1
Updated by Alexis Mousset about 1 year ago
- Description updated (diff)
- Target version changed from 8.1.0~alpha1 to 8.0.4
Updated by Alexis Mousset about 1 year ago
- Status changed from In progress to Pending technical review
- Assignee changed from Alexis Mousset to Félix DALLIDET
- Pull Request set to https://github.com/Normation/rudder/pull/5226
Updated by Alexis Mousset about 1 year ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|88b2c8ff7e82f17beb46edda3af18d903bd903f4.
Updated by Alexis Mousset about 1 year ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ about 1 year ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 8.0.4 which was released today.
Actions