Project

General

Profile

Actions

Bug #23446

open

Change request on special:all_nodes_without_role lead to error

Added by Elaad FURREEDAN 6 months ago. Updated about 1 month ago.

Status:
Pending release
Priority:
N/A
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
It bothers me each time
User visibility:
Effort required:
Large
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No

Description

Since we change the target rule name special:all_nodes_without_role to special:all_exceptPolicyServers (introduced by https://github.com/Normation/rudder/pull/4065)
When we access the change-request page, it generates an error in webapp logs

com.normation.rudder.domain.policies.RuleTarget - Error when trying to read the following serialized Rule target as a composite target: 'special:all_nodes_without_role'. Reported parsing error cause was: unknown token s
Near: sp

It seems that Eventlogs are also impacted by this change, since the contains ModifyRuleDiff


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #20460: Invalid attribute 'special:all_servers_with_role' (or special:all_nodes_without_role) for entry ruleTargetReleasedNicolas CHARLESActions
Actions #1

Updated by Elaad FURREEDAN 6 months ago

  • Related to Bug #20460: Invalid attribute 'special:all_servers_with_role' (or special:all_nodes_without_role) for entry ruleTarget added
Actions #2

Updated by Alexis Mousset 5 months ago

  • Target version changed from 7.2-next to 7.3
Actions #3

Updated by François ARMAND 3 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #4

Updated by François ARMAND 3 months ago

Since we don't have an understanding of the size of event log or existing change request with the old format, we will take an iterative migration solution:
- for event logs, just be able to read them: the one with the old format will tend to not be accessed after time (and if we still need, just log).
- for change request, read both new and old format, write only new.

It may have as a consequence that we need to keep forever that format, but eventlogs are not meant to be rewritten (perhaps a "cold storage" solution for them would be more appropriate, and migration would be done off line on the cold storage only)

Actions #5

Updated by François ARMAND 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5254
Actions #6

Updated by Anonymous 3 months ago

  • Status changed from Pending technical review to Pending release
Actions #7

Updated by Clark ANDRIANASOLO about 1 month ago

  • Fix check changed from To do to Checked
Actions

Also available in: Atom PDF