Bug #23446: Change request on special:all_nodes_without_role lead to error - Change validation - Issue Tracker

Actions

Copy link

Bug #23446

closed

Change request on special:all_nodes_without_role lead to error

Added by Elaad FURREEDAN about 1 year ago. Updated 6 months ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Target version:

Rudder plugins - 7.3

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

It bothers me each time

User visibility:

Effort required:

Large

Priority:

Name check:

To do

Fix check:

Checked

Regression:

Description

Since we change the target rule name special:all_nodes_without_role to special:all_exceptPolicyServers (introduced by https://github.com/Normation/rudder/pull/4065)
When we access the change-request page, it generates an error in webapp logs

com.normation.rudder.domain.policies.RuleTarget - Error when trying to read the following serialized Rule target as a composite target: 'special:all_nodes_without_role'. Reported parsing error cause was: unknown token s
Near: sp

It seems that Eventlogs are also impacted by this change, since the contains ModifyRuleDiff

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Elaad FURREEDAN about 1 year ago

Related to Bug #20460: Invalid attribute 'special:all_servers_with_role' (or special:all_nodes_without_role) for entry ruleTarget added

Actions

Copy link

Updated by Alexis Mousset about 1 year ago

Target version changed from 7.2-next to 7.3

Actions

Copy link

Updated by François ARMAND 12 months ago

Status changed from New to In progress
Assignee set to François ARMAND

Actions

Copy link

Updated by François ARMAND 12 months ago

Since we don't have an understanding of the size of event log or existing change request with the old format, we will take an iterative migration solution:
- for event logs, just be able to read them: the one with the old format will tend to not be accessed after time (and if we still need, just log).
- for change request, read both new and old format, write only new.

It may have as a consequence that we need to keep forever that format, but eventlogs are not meant to be rewritten (perhaps a "cold storage" solution for them would be more appropriate, and migration would be done off line on the cold storage only)

Actions

Copy link