User story #2399
closed
Change message for configuration changes
Added by François ARMAND about 12 years ago.
Updated almost 12 years ago.
Category:
Web - Config management
Description
We want to allow/force an user to add a change message describing why he just did what he did on a Technique/Directive/Rules/Group modification (and if possible when a user manually accept waiting changes).
The message would be asked in a pop-up. A Rudder configuration property must be added to allow to disabled the pop-up, show the pop-up but not require a message, show the pop-up and require a message.
Implementation:
- add a row in eventlog table to store commit message
- create the JS pop-up
- modify event log storage to accept external commit message.
- Status changed from 8 to In progress
All the back-end is up and working since commit ded679c7 :
- all events leading to and eventlog (and thus all action leading to the serialisation of a Rules/Group/Directive/ActiveTechnique) may be enhanced with a "reason" message
- that message is store in the database, in column "reason", and so the DB must be updated, see #2489
- that message is added to the commit message of the corresponding Git Commit (if any), leading to commit message looking like: "Directive XXXXX updated. Reason: User updated the directive with the UI". It was chosen to keep the first, automatic, part of the commit message to keep system information (directive UUID, for example), and be sur to always have a non empty message.
Now, we have to implement the browser (client) part of the feature, to allow user to chose their message.
- Status changed from In progress to Released
- Status changed from Released to Pending technical review
Oops, this needs a technical review, actually.
- Status changed from Pending technical review to 10
This is valid, however some old text remained from the 2.3 era, as stated in bug #2460
- Status changed from 10 to Released
This broadly works as expected, but see #2532 and #2533.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by