Project

General

Profile

Actions
Copy link

Bug #24111

closed

Pending deployment action are completely messed up

Added by Vincent MEMBRÉ 10 months ago. Updated 9 months ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Target version:
Rudder plugins - 7.3
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
I hate Rudder for that
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Priority:
132
Name check:
To do
Fix check:
To do
Regression:
No

Description

There is two action in pending validation "Deploy" popup from "Pending Deployment"
  • Pending Deployment
  • Deploy

Deploy (due to changes in #22601) change from step "penfing validation" to Deploy, but this fails because we are in "pending deployent" state. This fails with following message

2024-01-30 23:51:34+0100 ERROR change-validation - Cannot change status of ChangeRequest '15': it has the status 'Pending deployment' but we were expecting 'Pending validation'. Perhaps someone else changed it concurrently?

This may have been fixed by changes in #22993, but this add an action "Pending Deployment" Which in fact set the status from pending deployment to deploy, but why would click on this ? it makes you think that you do no change the step ? that's crazy

Fix is to go back to one step, that does the right thing

Related issues 2 (0 open — 2 closed)

Related to Change validation - Bug #22601: Missing validation button with adminReleasedVincent MEMBRÉActions
Related to Change validation - Bug #22993: Can't deploy, “Configuration state of the object modified by this change request has changed” loopingReleasedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ 10 months ago

  • Related to Bug #22601: Missing validation button with admin added
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ 10 months ago

  • Related to Bug #22993: Can't deploy, “Configuration state of the object modified by this change request has changed” looping added
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ 10 months ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ 10 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/641
Actions
Copy link
 #5

Updated by Anonymous 10 months ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ 10 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder plugin change-validation v8.0.5-2.3

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ 10 months ago

This bug has been fixed in Rudder plugin change-validation v7.3.11-2.3

Actions
Copy link
 #9

Updated by Elaad FURREEDAN 10 months ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • UX impact set to I hate Rudder for that
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Priority changed from 0 to 132
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ 9 months ago

This bug has been fixed in Rudder plugin change-validation v8.1.0.beta1-2.3

Actions
Copy link

Also available in: Atom PDF