Project

General

Profile

Actions

Bug #24236

closed

Overriding properties should have the same type as overridden

Added by Clark ANDRIANASOLO about 2 months ago. Updated about 1 month ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
I dislike using that feature
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Medium
Priority:
59
Name check:
To do
Fix check:
To do
Regression:
No

Description

With a global parameter of type json e.g. dns with value {"servers":["1.1.1.1"]}, it should not be possible to override the property with a raw string value e.g. "9.9.9.9" because it may break policy generation.

We have to :
  • enforce that a overriding property be of the same type as the overridden
  • warn about any existing inconsistencies within a node or group that overrides a property
  • warn heavily when changing the type of a property which already has overrides, knowing the hierarchy global parameter > group > node for properties inheritance. The user should have a list of affected groups or nodes when making such change
Actions #1

Updated by Clark ANDRIANASOLO about 2 months ago

  • Status changed from New to In progress
Actions #4

Updated by Vincent MEMBRÉ about 2 months ago

  • Target version changed from 8.1.0~beta1 to 8.1.0~beta2
  • Priority changed from 29 to 59
Actions #6

Updated by Clark ANDRIANASOLO about 1 month ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Clark ANDRIANASOLO to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/5471
Actions #7

Updated by Clark ANDRIANASOLO about 1 month ago

  • Status changed from Pending technical review to Pending release
Actions #8

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.1.0~beta2 which was released today.

Actions

Also available in: Atom PDF