Bug #24756: Accepting one selected pending node pops up a windows that accepts them all - Rudder - Issue Tracker

Actions

Copy link

Bug #24756

closed

Accepting one selected pending node pops up a windows that accepts them all

Added by Nicolas Ecarnot 13 days ago. Updated 7 days ago.

Status:

Released

Priority:

N/A

Assignee:

Clark ANDRIANASOLO

Category:

Web - Nodes & inventories

Target version:

8.1.1

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Major - prevents use of part of Rudder | no simple workaround

UX impact:

I hate Rudder for that

User visibility:

Getting started - demo | first install | Technique editor and level 1 Techniques

Effort required:

Priority:

142

Name check:

To do

Fix check:

Checked

Regression:

Yes

Description

Hello,

[8.1.0]

Having 5+ pending nodes, and selecting only one , when clicking on "Accept", the pop-up window is showing the whole list of ALL nodes about to be validated.

I'm setting it as regression as we never saw such a behaviour.

EDIT (from dev): the displayed list is incorrect but the nodes actually accepted/refused is the correct one (ie it's a display problem, we don't filter for selected node only in the displaying).

Files

clipboard-202404231120-vdnjl.png (135 KB) clipboard-202404231120-vdnjl.png

François ARMAND, 2024-04-23 11:20

Actions

Copy link

Updated by Alexis Mousset 13 days ago · Edited

Category set to Web - Nodes & inventories
Severity changed from Major - prevents use of part of Rudder | no simple workaround to Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact set to I hate Rudder for that
User visibility set to Getting started - demo | first install | Technique editor and level 1 Techniques
Priority changed from 0 to 166

Thanks for reporting! Setting severity to critical due to the potential security impact.

Actions

Copy link

Updated by Raphael GAUTHIER 13 days ago

Status changed from New to In progress
Assignee set to Raphael GAUTHIER

Actions

Copy link

Updated by François ARMAND 13 days ago

Assignee changed from Raphael GAUTHIER to François ARMAND

Actions

Copy link

Updated by François ARMAND 13 days ago

Status changed from In progress to Pending technical review
Assignee changed from François ARMAND to Clark ANDRIANASOLO
Pull Request set to https://github.com/Normation/rudder/pull/5619

PR https://github.com/Normation/rudder/pull/5619

Actions

Copy link

Updated by François ARMAND 13 days ago

Description updated (diff)
Severity changed from Critical - prevents main use of Rudder | no workaround | data loss | security to Major - prevents use of part of Rudder | no simple workaround
Priority changed from 166 to 142

So, analysing the problem, the list of accepted nodes is correct even if the list of in the pop-up is not.
Thus it's a bit less critical, it does not impact security. Still a major problem and a regression of course.

The PR corrects the displaying to be what is actually selected.

Actions

Copy link