Architecture #25092
closedArchitecture #24963: Persist compliance in base to know last state for a long time
Refactor CachedReportingService to make persistance simpler
Description
CachedReportingService is very complicated and mix at least four function (getting runs & expected config, computing compliance and checking compliance, having a cache, and higher level utility methods on NodeStatusReport).
We want to split these different part to have a clear NodeStatusReportRepository
where to add persistance, and a clear ComputeNodeStatusReports
where to modify expiration checks based on new parameter.
This first step should not modify too much current implementation, just simplify things where it's obvious (unused parameters, etc).
It's also time to get ride of the all-commented ReportingServiceTest
, so that we can build a simpler, better suite afterward.