Actions
Bug #25490
closedBug #25479: Users cleanup configuration is too strict on disabled users
User cleanup actions are logged every time even there is no change
Pull Request:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
It bothers me each time
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Very Small
Priority:
73
Name check:
To do
Fix check:
Checked
Regression:
No
Description
I set up the clean cron to check every minute for users to cleanup : rudder.users.cleanup.cron=0 * * * * ?
But there is a warning log and many other info logs even if there are no changes at all :
2024-09-18 14:20:00+0200 WARN application.authentication - Following users status changed to 'disabled' because they were inactive since 'PT1H': '' 2024-09-18 14:20:00+0200 INFO application.authentication - Following users status changed from 'disabled' to 'deleted': '' 2024-09-18 14:20:00+0200 INFO application.authentication - Users were purged from the database because they were configured to be purged PT720H after deletion. Users list is : '' 2024-09-18 14:20:00+0200 INFO application.user - 0 user sessions older than 2024-08-19T14:20:00+02:00 were deleted 2024-09-18 14:20:00+0200 INFO application.authentication - Log of user sessions older than 2024-08-19T14:20:00+02:00 were deleted 2024-09-18 14:20:00+0200 INFO application.authentication - Cleaning user accounts and sessions performed in PT0.010SThere should be no logs when there are no changes in the user database, also there are several issues :
- the sessions deletion log are duplicated, we should keep the first one which has the count of deleted sessions
- when users have been changed, the separator spacing is wrong :
'user1' ,'user2' ,'user3'
Actions