Project

General

Profile

Actions

Bug #25503

open

Changes on system objects should not have rollback and links in events logs

Added by Clark ANDRIANASOLO 3 months ago. Updated 20 days ago.

Status:
New
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
Trivial - no functional impact | cosmetic
UX impact:
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Small
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No

Description

When consulting event logs and searching for events on system directives and rules (e.g. the one created for system-updates campaigns), I can get a link on those objects and access a page that is supposed to be hidden for them, I can even attempt to rollback those events :

Hopefully, attempting a rollback leads to an error :

2024-09-20 10:13:47+0000 INFO  api-processing.response-error - "Error when performing eventlog's rollback with id '123' <- The event log 123 don't have a matching commit ID and can't be restored" 

Also the objects end up not being modifiable in the Directives and Rules pages (thanks to the API enforcing that system directives and rules are not modifiable).

We should hide the rollback section for system objects, and links should not be generated for new event logs on those objects


Files

Peek 2024-09-20 12-16.gif (1.6 MB) Peek 2024-09-20 12-16.gif Clark ANDRIANASOLO, 2024-09-20 14:25

Related issues 1 (1 open0 closed)

Related to Rudder - Bug #25518: System rules and directives details page should not have action buttons NewActions
Actions #1

Updated by Clark ANDRIANASOLO 3 months ago

I can also clone the directive/rule and cloning a directives ends up with a directives with the systemUpdateCampaign technique category (but with attribute isSystem to false).
However, the update campaigns page does not list the cloned campaign directive.

It would still be possible to run campaigns by changing the parameters to the cloned directive, and assign a new rule for it (via API to assign the cloned directive ID).
I think this is not supposed to be an allowed usage, and the system objects should not be visible in the directives web page, nor in the API

Actions #2

Updated by Clark ANDRIANASOLO 3 months ago

  • Related to Bug #25518: System rules and directives details page should not have action buttons added
Actions #3

Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 8.1.8 to 8.1.9
Actions #4

Updated by Vincent MEMBRÉ 25 days ago

  • Target version changed from 8.1.9 to 8.1.10
Actions #5

Updated by Vincent MEMBRÉ 20 days ago

  • Target version changed from 8.1.10 to 8.1.11
Actions

Also available in: Atom PDF