Bug #25542: inventories with utf8 software don't show up with utf8 software in the ui - Rudder - Issue Tracker

Actions

Copy link

Bug #25542

open

inventories with utf8 software don't show up with utf8 software in the ui

Added by Nicolas CHARLES 3 months ago. Updated 20 days ago.

Status:

New

Priority:

Assignee:

Category:

Web - Nodes & inventories

Target version:

8.1.11

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

To do

Fix check:

To do

Regression:

Description

inventory contains

    <SOFTWARES>
      <ARCH>x86_64</ARCH>
      <FROM>registry</FROM>
      <GUID>{90150000-001F-0403-1000-0000000FF1CE}</GUID>
      <INSTALLDATE>25/09/2024</INSTALLDATE>
      <NAME>Microsoft Office Proofing Tools 2013 B€r#{| ¤*ﮝﮄﮔשׁﯺﻶ</NAME>
      <SYSTEM_CATEGORY>application</SYSTEM_CATEGORY>
      <VERSION>15.0.4569.1506</VERSION>
    </SOFTWARES>

Files

Download all files

AGENT2-b07d54bf-ca1e-4a0f-8a6d-a1b67caa26a3.ocs.sign (1.12 KB) AGENT2-b07d54bf-ca1e-4a0f-8a6d-a1b67caa26a3.ocs.sign		Nicolas CHARLES, 2024-09-25 12:43
AGENT2-b07d54bf-ca1e-4a0f-8a6d-a1b67caa26a3.ocs (37.8 KB) AGENT2-b07d54bf-ca1e-4a0f-8a6d-a1b67caa26a3.ocs		Nicolas CHARLES, 2024-09-25 12:43
clipboard-202409251243-7d4vh.png (40.6 KB) clipboard-202409251243-7d4vh.png		Nicolas CHARLES, 2024-09-25 12:43
clipboard-202409261704-6fhsx.png (53.5 KB) clipboard-202409261704-6fhsx.png		François ARMAND, 2024-09-26 17:04
clipboard-202409261704-wegit.png (21.2 KB) clipboard-202409261704-wegit.png		François ARMAND, 2024-09-26 17:04
2024-10-01_17-35.png (17.9 KB) 2024-10-01_17-35.png		Félix DALLIDET, 2024-10-01 17:35

Related issues 3 (1 open — 2 closed)

Actions

Copy link

Updated by François ARMAND 3 months ago

Related to Bug #25395: Fusion inventory fails to report software with exotic names - some entries randomly disappear added

Actions

Copy link

Updated by François ARMAND 3 months ago

Assignee set to François ARMAND
Priority changed from N/A to 1 (highest)

Actions

Copy link

Updated by François ARMAND 3 months ago

Status changed from New to In progress

Actions

Copy link Download all files

Updated by François ARMAND 3 months ago

File clipboard-202409261704-6fhsx.png clipboard-202409261704-6fhsx.png added
File clipboard-202409261704-wegit.png clipboard-202409261704-wegit.png added

So, I can reproduce it. It's not a parsing problem, nor a save problem: it's OK in LDAP:

But the UI shows:

Actions

Copy link

Updated by François ARMAND 3 months ago

Target version changed from 8.2.0~rc1 to 8.1.8

I think it's just a display problem in fact.

Actions

Copy link

Updated by François ARMAND 3 months ago

Priority changed from 1 (highest) to 2

(and so it's less prioritary)

Actions

Copy link

Updated by François ARMAND 3 months ago · Edited

It's our escapreJs method that does that in DisplayNode:

private def escapeJs(in:   String):         JsExp   = Str(StringEscapeUtils.escapeEcmaScript(in))

It means that it's not very grave, and that the correction will need special care to not introduce a security vulnerability

Actions

Copy link

Updated by François ARMAND 3 months ago · Edited

And it's a special weekness of the lib: https://stackoverflow.com/a/59332501

Actions

Copy link

Updated by Félix DALLIDET 3 months ago

File 2024-10-01_17-35.png 2024-10-01_17-35.png added

I have a similar issue with newlines in the compliance that could be related.
If a report message contains newlines, they are no longer displayed in the compliance webpage.

See the example below:

 psql -U rudder -h localhost -c "select * from ruddersysevents where nodeid ='276a47dd-2afc-4d98-a88c-41b20cedae75' order by id desc" 
 37085 | Expression 'true' evaluates to true,  A message with                                                                                                                                                                                          +
       | some                                                                                                                                                                                                                                          +
       | new                                                                                                                                                                                                                                           +
       | lines                                                                                                                                                                                                                                         +
       | and a                                                                                                                                                                                                                                         +
       | \n                                                                                                                                                                                                                                            +
       | just to see was correct

Using an input like such:

id: linux_one
name: Linux one
version: '1.0'
category: ncf_techniques
items:
  - id: 6e6dcbf9-1ade-4b0b-962a-bbd8b2f20dcb
    name: ''
    method: report_if_condition
    params:
      report_message: |-
        A message with
        some
        new
        lines
        and a
        \n
        just to see
      condition: 'true'

The compliance is "broken" as the newlines are removed from the message content.

Actions

Copy link

#10