Project

General

Profile

Actions
Copy link

Bug #25635

closed

Chunk appending when resolving node ids from union target can be optimized

Added by Clark ANDRIANASOLO 3 months ago. Updated about 1 month ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Architecture - Code maintenance
Target version:
8.1.8
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Trivial - no functional impact | cosmetic
UX impact:
User visibility:
Effort required:
Very Small
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No

Description

The specialized ++ seems to be more optimized than the generic concat inherited from the iterable API, which probably makes the resolution of node ids from targets probably less optimized.

We could test with ++ to see the difference

Actions
Copy link
 #1

Updated by Clark ANDRIANASOLO 3 months ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by Clark ANDRIANASOLO 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Clark ANDRIANASOLO to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/5925
Actions
Copy link
 #3

Updated by Clark ANDRIANASOLO 3 months ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 1 month ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.1.8 and 8.2.1 which were released today.

Actions
Copy link

Also available in: Atom PDF