Project

General

Profile

Actions
Copy link

Bug #25704

open

event log detail show shouldBeReplacedByDiff

Added by Nicolas CHARLES 9 months ago. Updated 9 days ago.

Status:
New
Priority:
2
Assignee:
François ARMAND
Category:
Web - Maintenance
Target version:
8.2.8
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No

Description

A node modified diff displays shouldBeReplacedByDiff

Files

Download all files
clipboard-202410181316-p8zqg.png (77 KB) clipboard-202410181316-p8zqg.png Nicolas CHARLES, 2024-10-18 13:16
clipboard-202411281718-svnul.png (138 KB) clipboard-202411281718-svnul.png François ARMAND, 2024-11-28 17:18
clipboard-202411281720-babn0.png (87 KB) clipboard-202411281720-babn0.png François ARMAND, 2024-11-28 17:20
clipboard-202507030948-7ah7q.png (143 KB) clipboard-202507030948-7ah7q.png Nicolas CHARLES, 2025-07-03 09:48

Subtasks 2 (0 open — 2 closed)

Bug #25977: Node update event does not correctly record old nodeReleasedClark ANDRIANASOLOActions
Bug #25978: CustomProperties (inventory properties) are not always correctly retrieved from inventoryReleasedClark ANDRIANASOLOActions

Related issues 2 (2 open — 0 closed)

Related to Rudder - Bug #27114: Many diffs no longer display in event logs Pending releaseFrançois ARMANDActions
Related to Rudder - Bug #27185: CSP error in change logs pagesNewClark ANDRIANASOLOActions
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 8.2.0 to 8.2.1
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 8.2.1 to 8.2.2
Actions
Copy link
 #3

Updated by Nicolas CHARLES 8 months ago

  • Assignee set to François ARMAND
  • Priority changed from N/A to 2

Exists also probably in 8.1
to reproduce: have a node with property, send an inventory with node inventory properties, you get this result

Actions
Copy link
 #4

Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 8.2.2 to 8.2.3
Actions
Copy link
 #5

Updated by François ARMAND 8 months ago

So, the problem is that storage.save(updated) is lying:

- it always return inventory properties in the new part, but not in the old node part of the event,
- it does not return the change in rudder settings: it seens in both case the new value.

Actions
Copy link
 #6

Updated by François ARMAND 8 months ago

  • Target version changed from 8.2.3 to 8.1.10

It happens in 8.1 too.

Actions
Copy link Download all files
 #7

Updated by François ARMAND 8 months ago

"updated" and "s.newNode" have the correct values:

but s.oldNode doesn't:

Actions
Copy link
 #8

Updated by François ARMAND 8 months ago

  • Subtask #25977 added
Actions
Copy link
 #9

Updated by François ARMAND 8 months ago

  • Subtask #25978 added
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 8.1.10 to 8.1.11
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 8.1.11 to 8.1.12
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 8.1.12 to 8.1.13
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 8.1.13 to 8.2.6
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 8.2.6 to 8.2.7
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 8.2.7 to 8.2.8
Actions
Copy link
 #16

Updated by Nicolas CHARLES 9 days ago

I'm having these error in 8.3, might be related

Actions
Copy link
 #17

Updated by Clark ANDRIANASOLO 9 days ago

If it is only a display issue, it looks like a duplicate (special case) of #27114, the diff for node properties is indeed using the javascript library jsondiffpatch but it cannot be called due to strict CSP headers

Actions
Copy link
 #18

Updated by Clark ANDRIANASOLO 9 days ago

  • Related to Bug #27114: Many diffs no longer display in event logs added
Actions
Copy link
 #19

Updated by Nicolas CHARLES 9 days ago

  • Related to Bug #27185: CSP error in change logs pages added
Actions
Copy link

Also available in: Atom PDF