Bug #26264
open
The refresh button from the nodes webpage change the list of nodes in the other tab
Added by Félix DALLIDET 2 months ago.
Updated 21 days ago.
UX impact:
I hate Rudder for that
User visibility:
First impressions of Rudder
Effort required:
Very Small
Description
If I click on the "refresh" button on the nodes webpage, it remove all the nodes from the list and I have to reload the entire page to see them back
Files
There is a bug in the front-end side : it passes no arguments for nodeIds when fetching node details from the API

But when reloading, it passes some node ids, apparently excluding the root server :

It should always pass an empty list
Changes have been made in #26055 with the new tab structure in the same page, but the state of the two different node tables seems to be linked : when changing search criteria in the Search
tab, the table is refreshed, but when refreshing the main list of nodes in the List
table, the criteria is the same.
It is due to a shared global variable nodeIds
, which is shared by both tables. It will need to be isolated for each table.
So, we checked and we can confirm that the problem is only on search, and in the case of top post, likely the last search was not returning any node.
So we need to scope nodeIds
js variable to be linked to only one datatable.
By default, we should also NOT init the search table, since it's strange to have all nodes when you come to the page. And it's bad from a perf since ALL nodes are returned.
- Status changed from New to In progress
- Assignee set to Raphael GAUTHIER
- Subject changed from The refresh button from the Node webpage flushes all nodes to The refresh button from the nodes webpage change the list of nodes in the other tab
- Related to Bug #26260: The "Edit columns" button in the nodes webpage is displayed three times added
- Assignee changed from Raphael GAUTHIER to Clark ANDRIANASOLO
- Status changed from In progress to Pending technical review
- Pull Request set to https://github.com/Normation/rudder/pull/6222
- Assignee changed from Clark ANDRIANASOLO to Raphael GAUTHIER
- Target version changed from 8.3.0~beta1 to 8.3.0~beta2
- Status changed from Pending technical review to Pending release
Also available in: Atom
PDF