Bug #26483: Error when trying to add a node property when “Change audit logs” are mandatory - Rudder - Issue Tracker

Actions

Copy link

Bug #26483

closed

Error when trying to add a node property when “Change audit logs” are mandatory

Added by Michel BOUISSOU 2 months ago. Updated 1 day ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Clark ANDRIANASOLO

Category:

Target version:

8.2.6

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

I dislike using that feature

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Priority:

Name check:

To do

Fix check:

Checked

Regression:

Description

Rudder 8.2.5

If both “Enable change audit logs” and “Make logs messages mandatory” are checked in Rudder server config, then trying to add a node property in the node's properties page results in error message : « Error when Saving node propertie, details : The server had a problem, try again later »

The webapp log shows :

INFO  api-processing.response-error - An error occurred while updating Node 'fc726a00-dfe8-497a-b1c1-8543d3468c94'; cause was: There was an error while extracting reason message; cause was: Inconsistency: Reason field is mandatory and should be at least 5 characters long

Making the audit log messages non mandatory solves this.

Subtasks 1 (0 open — 1 closed)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES 2 months ago

Related to Bug #10578: Cannot add node property when audit message is mandatory added

Actions

Copy link

Updated by François ARMAND 2 months ago

We used to have a default message automatically added in that case, see correction in 4.1: https://github.com/Normation/rudder/pull/1627/files

Actions

Copy link

Updated by François ARMAND 2 months ago

Assignee set to Clark ANDRIANASOLO
Priority changed from To review to 1 (highest)

It's P1 because the only workaround is to disable the audit message which is often a mandatory requirement in Big Companies

Actions

Copy link

Updated by Clark ANDRIANASOLO 2 months ago

Status changed from New to In progress

Actions

Copy link

Updated by Clark ANDRIANASOLO 2 months ago

Status changed from In progress to New

This happens on every attempt to update properties (adding one, removing one, deleting one from the UI, in fact it is the same POST /api/nodes/{node_id} in the API, which suffers from the same problem).

From the groups page, it works though (and it is also a "group update" in the REST API)

But in the request, there is a reason field in the API request from both places, so it is likely a problem in the Node API only, which expects a mandatory reason :

>>> curl  -X POST  -H "X-API-TOKEN: $(cat /var/rudder/run/api-token)" http://localhost:8081/rudder/api/latest/nodes/root -H "Content-Type: application/json" --data '{"properties":[{"name":"audit","value":"testtest"}],"reason":"ras"}'
{"action":"updateNode","result":"error","errorDetails":"An error occurred while updating Node 'root'; cause was: There was an error while extracting reason message; cause was: Inconsistency: Reason field is mandatory and should be at least 5 characters long"}

Actions

Copy link

Updated by Clark ANDRIANASOLO 2 months ago · Edited

It does not cause an issue in the groups API, nor directives and rules APIs, that seem to ignore the reason field.

But there are several inconsistencies in the Rudder UI which need to be fixed too, or else the mandatory checks will be bypassed :

groups can be created without a reason field (defaults as empty string)
rules do not validate the reason length (it needs to be at least 5 chars long), but prevents saving by disabling the button if the field is empty (allows it when field is blank, it does not seem to trim whitespaces from the string)

Actions

Copy link